Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 2890863002: cocoa: move first run bubble's arrow (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 9416253c7bbda8d8189a5ecdcdec658025fb8971..0d693a66773346da82f3595210ee49631b66fe87 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -651,15 +651,9 @@ new ManagePasswordsDecoration(command_updater, this)),
if (!field_ || ![field_ window])
return;
- // The first run bubble's left edge should line up with the left edge of the
- // omnibox. This is different from other bubbles, which line up at a point
- // set by their top arrow. Because the BaseBubbleController adjusts the
- // window origin left to account for the arrow spacing, the first run bubble
- // moves the window origin right by this spacing, so that the
- // BaseBubbleController will move it back to the correct position.
- const NSPoint kOffset = NSMakePoint(
- info_bubble::kBubbleArrowXOffset + info_bubble::kBubbleArrowWidth/2.0,
- kFirstRunBubbleYOffset);
+ // Point the bubble's arrow at the middle of the bottom of the page info icon.
+ const NSPoint kOffset =
+ NSMakePoint(info_bubble::kBubbleArrowXOffset, kFirstRunBubbleYOffset);
[FirstRunBubbleController showForView:field_
offset:kOffset
browser:browser_
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698