Simplify TranslateRanker API.

Simplify TranslateRanker API.

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG=723739
Review-Url: https://codereview.chromium.org/2890843003
Cr-Commit-Position: refs/heads/master@{#473918}
Committed: https://chromium.googlesource.com/chromium/src/+/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96

[hamelphi, 2017-05-17 17:51:07]

hamelphi@chromium.org changed reviewers:
+ groby@chromium.org, rogerm@chromium.org

[hamelphi, 2017-05-18 20:51:12]

On 2017/05/17 17:51:08, hamelphi wrote:

Ping! Can I haz review?

I hope to get this in by Friday for the MON fixit week and get those sweet sweet
Product Excellence points :).

[Roger McFarlane (Chromium), 2017-05-18 21:01:32]

lgtm

https://codereview.chromium.org/2890843003/diff/1/components/translate/core/b...
File components/translate/core/browser/translate_ranker_impl_unittest.cc
(right):

https://codereview.chromium.org/2890843003/diff/1/components/translate/core/b...
components/translate/core/browser/translate_ranker_impl_unittest.cc:47: //
Returns a TranslateRankerImpl object with |threshold| for testing.
add a comment that the returned ranker is configured to not invoke the model
loader (i.e., empty cache path and url).

[hamelphi, 2017-05-18 21:25:13]

https://codereview.chromium.org/2890843003/diff/1/components/translate/core/b...
File components/translate/core/browser/translate_ranker_impl_unittest.cc
(right):

https://codereview.chromium.org/2890843003/diff/1/components/translate/core/b...
components/translate/core/browser/translate_ranker_impl_unittest.cc:47: //
Returns a TranslateRankerImpl object with |threshold| for testing.
On 2017/05/18 21:01:32, Roger McFarlane (Chromium) wrote:
> add a comment that the returned ranker is configured to not invoke the model
> loader (i.e., empty cache path and url).

Done.

[groby-ooo-7-16, 2017-05-23 14:06:31]

lgtm

[hamelphi1, 2017-05-23 14:09:26]

The CQ bit was checked by hamelphi@google.com

[hamelphi1, 2017-05-23 14:09:26]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerm@chromium.org
Link to the patchset: https://codereview.chromium.org/2890843003/#ps20001
(title: "Add comment about GetRankerForTest.")

[commit-bot: I haz the power, 2017-05-23 14:09:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 14:11:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 14:11:51]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[hamelphi1, 2017-05-23 14:51:08]

The CQ bit was checked by hamelphi@google.com

[hamelphi1, 2017-05-23 14:51:08]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerm@chromium.org,
groby@chromium.org
Link to the patchset: https://codereview.chromium.org/2890843003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-23 14:51:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 15:55:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495551068084070,
"parent_rev": "fcf472038605e8554a6c7e75f0f159ebdaa73299", "commit_rev":
"e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96"}

[commit-bot: I haz the power, 2017-05-23 15:56:17]

Description was changed from

==========
Simplify TranslateRanker API.

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies
the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG=723739
==========

to

==========
Simplify TranslateRanker API.

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies
the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG=723739

Review-Url: https://codereview.chromium.org/2890843003
Cr-Commit-Position: refs/heads/master@{#473918}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3fe5e855cb0ecae33620fbfbb65...
==========

[commit-bot: I haz the power, 2017-05-23 15:56:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e3fe5e855cb0ecae33620fbfbb65...

[hamelphi, 2017-05-24 14:16:39]

Description was changed from

==========
Simplify TranslateRanker API.

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies
the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG=723739

Review-Url: https://codereview.chromium.org/2890843003
Cr-Commit-Position: refs/heads/master@{#473918}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3fe5e855cb0ecae33620fbfbb65...
==========

to

==========
Simplify TranslateRanker API.

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies
the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG=723739

Review-Url: https://codereview.chromium.org/2890843003
Cr-Commit-Position: refs/heads/master@{#473918}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3fe5e855cb0ecae33620fbfbb65...
==========

[hamelphi, 2017-05-24 14:16:39]

hamelphi@chromium.org changed reviewers:
- hamelphi@google.com