components/translate/core/browser/mock_translate_ranker.cc - Issue 2890843003: Simplify TranslateRanker API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/mock_translate_ranker.cc

Issue 2890843003: Simplify TranslateRanker API. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/mock_translate_ranker.cc

diff --git a/components/translate/core/browser/mock_translate_ranker.cc b/components/translate/core/browser/mock_translate_ranker.cc

index a96813add84f53ad58f75d0b4b52fdee87b2be3c..1aa3d14c02d417a2f9890eb48b2c1fe22c52ea8f 100644

--- a/components/translate/core/browser/mock_translate_ranker.cc

+++ b/components/translate/core/browser/mock_translate_ranker.cc

@@ -19,9 +19,6 @@ uint32_t MockTranslateRanker::GetModelVersion() const {

}

bool MockTranslateRanker::ShouldOfferTranslation(

- const TranslatePrefs& /* translate_prefs */,

- const std::string& /* src_lang */,

- const std::string& /* dst_lang */,

metrics::TranslateEventProto* /*translate_event */) {

return should_offer_translation_;

}