Adding ThreadChecker validation to d'tors for protocol classes

Adding ThreadChecker validation to d'tors for protocol classes

There was an incorrect assumption about how ThreadChecker worked which lead
to several classes not having the d'tor guarantees they expected.  The
assumption was that a ThreadChecker would DCHECK if it was not destroyed on
the same thread it was bound to.  This is not correct so I am adding DCHECKs
to the d'tors of the remoting classes which were missed.

BUG=715633
Review-Url: https://codereview.chromium.org/2890833002
Cr-Commit-Position: refs/heads/master@{#472507}
Committed: https://chromium.googlesource.com/chromium/src/+/18837eb479d946f6fd741791b2de20311235672f

[joedow, 2017-05-17 16:20:31]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 16:21:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 17:05:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:05:04]

Dry run: This issue passed the CQ dry run.

[joedow, 2017-05-17 17:19:14]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2017-05-17 17:19:15]

PTAL!

[Sergey Ulanov, 2017-05-17 17:43:09]

LGTM.
Thank you for these fixes!

[joedow, 2017-05-17 18:16:11]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2017-05-17 18:17:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:28:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495044971464520, "parent_rev":
"a1d159d88e6b302061a629bdc368609ba50b08b6", "commit_rev":
"18837eb479d946f6fd741791b2de20311235672f"}

[commit-bot: I haz the power, 2017-05-17 18:28:41]

Description was changed from

==========
Adding ThreadChecker validation to d'tors for protocol classes

There was an incorrect assumption about how ThreadChecker worked which lead
to several classes not having the d'tor guarantees they expected.  The
assumption was that a ThreadChecker would DCHECK if it was not destroyed on
the same thread it was bound to.  This is not correct so I am adding DCHECKs
to the d'tors of the remoting classes which were missed.

BUG=715633
==========

to

==========
Adding ThreadChecker validation to d'tors for protocol classes

There was an incorrect assumption about how ThreadChecker worked which lead
to several classes not having the d'tor guarantees they expected.  The
assumption was that a ThreadChecker would DCHECK if it was not destroyed on
the same thread it was bound to.  This is not correct so I am adding DCHECKs
to the d'tors of the remoting classes which were missed.

BUG=715633

Review-Url: https://codereview.chromium.org/2890833002
Cr-Commit-Position: refs/heads/master@{#472507}
Committed:
https://chromium.googlesource.com/chromium/src/+/18837eb479d946f6fd741791b2de...
==========

[commit-bot: I haz the power, 2017-05-17 18:28:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18837eb479d946f6fd741791b2de...