remoting/protocol/webrtc_frame_scheduler_simple.cc - Issue 2890833002: Adding ThreadChecker validation to d'tors for protocol classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/webrtc_frame_scheduler_simple.cc

Issue 2890833002: Adding ThreadChecker validation to d'tors for protocol classes (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/webrtc_frame_scheduler_simple.cc

diff --git a/remoting/protocol/webrtc_frame_scheduler_simple.cc b/remoting/protocol/webrtc_frame_scheduler_simple.cc

index 526ba6125a28cbd40a324bc501a02a7ccefe4f94..3d9e6a477059797d47413529ef73253e36e28d6f 100644

--- a/remoting/protocol/webrtc_frame_scheduler_simple.cc

+++ b/remoting/protocol/webrtc_frame_scheduler_simple.cc

@@ -128,7 +128,9 @@ WebrtcFrameSchedulerSimple::WebrtcFrameSchedulerSimple()

updated_region_area_(kStatsWindow),

weak_factory_(this) {}

-WebrtcFrameSchedulerSimple::~WebrtcFrameSchedulerSimple() {}

+WebrtcFrameSchedulerSimple::~WebrtcFrameSchedulerSimple() {

+ DCHECK(thread_checker_.CalledOnValidThread());

void WebrtcFrameSchedulerSimple::OnKeyFrameRequested() {

DCHECK(thread_checker_.CalledOnValidThread());