SafeBrowsing: allow WebView to customize the Help Center URL

chrome/browser/safe_browsing/ui_manager_unittest.cc

Index: chrome/browser/safe_browsing/ui_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/ui_manager_unittest.cc b/chrome/browser/safe_browsing/ui_manager_unittest.cc
index 174936a1914539db72ac6501d6ec4a1c7ee7b061..a57a1a61112cf0c14928dce56b711433634a5228 100644
--- a/chrome/browser/safe_browsing/ui_manager_unittest.cc
+++ b/chrome/browser/safe_browsing/ui_manager_unittest.cc
@@ -351,7 +351,8 @@ class TestSafeBrowsingBlockingPage : public SafeBrowsingBlockingPage {
                 false,
                 false,
                 false,
-                BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources))) {
+                BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources),
+                nullptr)) {

[Jialiu Lin, 2017/05/17 15:47:46]

nit: add some inline comment.

[Nate Fischer, 2017/05/17 22:34:43]

Acknowledged. I'm assigning the value from a function call now, so the meaning
should be clear. Let me know if you'd still like an explanatory comment. I added
comments for all the `false`s, to make them clearer.

[Nate Fischer, 2017/05/19 00:13:32]

I couldn't get the method to actually work nicely, so I just hard code the
string literal instead. I added a comment in the latest patchset.

     // Don't delay details at all for the unittest.
     SetThreatDetailsProceedDelayForTesting(0);
     DontCreateViewForTesting();