SafeBrowsing: allow WebView to customize the Help Center URL

chrome/browser/safe_browsing/ui_manager_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/ui_manager.h"
 
 #include "base/run_loop.h"
 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/safe_browsing/ui_manager.h"
@@ skipping 333 matching lines @@
             web_contents,
             main_frame_url,
             unsafe_resources,
             BaseSafeBrowsingErrorUI::SBErrorDisplayOptions(
                 BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources),
                 false,
                 false,
                 false,
                 false,
                 false,
-                BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources))) {
+                BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources),
+                nullptr)) {

[Jialiu Lin, 2017/05/17 15:47:46]

nit: add some inline comment.

[Nate Fischer, 2017/05/17 22:34:43]

Acknowledged. I'm assigning the value from a function call now, so the meaning
should be clear. Let me know if you'd still like an explanatory comment. I added
comments for all the `false`s, to make them clearer.

[Nate Fischer, 2017/05/19 00:13:32]

I couldn't get the method to actually work nicely, so I just hard code the
string literal instead. I added a comment in the latest patchset.

     // Don't delay details at all for the unittest.
     SetThreatDetailsProceedDelayForTesting(0);
     DontCreateViewForTesting();
   }
 };
 
 // A factory that creates TestSafeBrowsingBlockingPages.
 class TestSafeBrowsingBlockingPageFactory
     : public SafeBrowsingBlockingPageFactory {
  public:
@@ skipping 49 matching lines @@
   SimulateBlockingPageDone(resources, true);
   EXPECT_TRUE(delegate.visible_security_state_changed());
 
   waiter.WaitForCallback();
   EXPECT_TRUE(waiter.callback_called());
   EXPECT_TRUE(waiter.proceed());
   EXPECT_TRUE(IsWhitelisted(resource));
 }
 
 }  // namespace safe_browsing