chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc - Issue 2890703002: SafeBrowsing: allow WebView to customize the Help Center URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 2890703002: SafeBrowsing: allow WebView to customize the Help Center URL (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/safe_browsing/ui_manager_unittest.cc » ('j') | chrome/browser/safe_browsing/ui_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

index 5690dac0145b2484c15228bf02fd6d507c2a3bdb..b85d775b62aabb14a77471bbacd82ddc0901358b 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

@@ -86,7 +86,8 @@ class TestSafeBrowsingBlockingPageFactory

web_contents->GetBrowserContext()->IsOffTheRecord(),

IsExtendedReportingEnabled(*prefs), IsScout(*prefs),

is_proceed_anyway_disabled,

- BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources));

+ BaseBlockingPage::IsMainPageLoadBlocked(unsafe_resources),

+ nullptr);

return new TestSafeBrowsingBlockingPage(manager, web_contents,

main_frame_url, unsafe_resources,

display_options);