Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2890603005: Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default (Closed)

Created:
3 years, 7 months ago by Bryan McQuade
Modified:
3 years, 7 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default (patchset #1 id:1 of https://codereview.chromium.org/2887773003/ ) Reason for revert: Reverting based on findit-for-me notification Original issue's description: > [PageLoadMetrics] Enable AdsPageLoadMetrics by default > > Now that we've addressed all of the known causes of crashes, it's time to > reenable. > > BUG=708570 > > Review-Url: https://codereview.chromium.org/2887773003 > Cr-Commit-Position: refs/heads/master@{#472248} > Committed: https://chromium.googlesource.com/chromium/src/+/6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26 TBR=jkarlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708570 Review-Url: https://codereview.chromium.org/2890603005 Cr-Commit-Position: refs/heads/master@{#472285} Committed: https://chromium.googlesource.com/chromium/src/+/bbfd1d204f097c0dc0e48de1b4cca0169aaf35e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Bryan McQuade
Created Revert of [PageLoadMetrics] Enable AdsPageLoadMetrics by default
3 years, 7 months ago (2017-05-17 02:02:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890603005/1
3 years, 7 months ago (2017-05-17 02:05:39 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 02:07:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bbfd1d204f097c0dc0e48de1b4cc...

Powered by Google App Engine
This is Rietveld 408576698