Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2887773003:
[PageLoadMetrics] Enable AdsPageLoadMetrics by default (Closed)
|
Created:
3 years, 7 months ago by jkarlin Modified:
3 years, 7 months ago Reviewers:
Bryan McQuade CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[PageLoadMetrics] Enable AdsPageLoadMetrics by default
Now that we've addressed all of the known causes of crashes, it's time to
reenable.
BUG=708570
Review-Url: https://codereview.chromium.org/2887773003
Cr-Commit-Position: refs/heads/master@{#472248}
Committed: https://chromium.googlesource.com/chromium/src/+/6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 17 (9 generated)
Description was changed from ========== [PageLoadMetrics] Enable AdsPageLoadMetrics by default Now that we've addressed all of the known causes of crashes, it's time to reenable. BUG=708570 ========== to ========== [PageLoadMetrics] Enable AdsPageLoadMetrics by default Now that we've addressed all of the known causes of crashes, it's time to reenable. BUG=708570 ==========
jkarlin@chromium.org changed reviewers: + bmcquade@chromium.org
bmcquade@ PTAL, I won't commit this until https://codereview.chromium.org/2884753002/ lands.
lgtm
The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jkarlin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494976508546940, "parent_rev":
"001f6234b60a15a1b009a3df5089e2adc9cde03b", "commit_rev":
"6c08596b40d0fb9e1d66ca96b65b2d1a707fcb26"}
Message was sent while issue was closed.
Description was changed from ========== [PageLoadMetrics] Enable AdsPageLoadMetrics by default Now that we've addressed all of the known causes of crashes, it's time to reenable. BUG=708570 ========== to ========== [PageLoadMetrics] Enable AdsPageLoadMetrics by default Now that we've addressed all of the known causes of crashes, it's time to reenable. BUG=708570 Review-Url: https://codereview.chromium.org/2887773003 Cr-Commit-Position: refs/heads/master@{#472248} Committed: https://chromium.googlesource.com/chromium/src/+/6c08596b40d0fb9e1d66ca96b65b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6c08596b40d0fb9e1d66ca96b65b...
Message was sent while issue was closed.
Findit (https://goo.gl/kROfz5) identified this CL at revision 472248 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Message was sent while issue was closed.
On 2017/05/17 at 01:47:10, findit-for-me wrote: > Findit (https://goo.gl/kROfz5) identified this CL at revision 472248 as the culprit for > failures in the build cycles as shown on: > https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb... Josh, I can't confirm that this is causing the test failures, but I'll go ahead and trust this notification and assume we should revert. Can investigate tomorrow.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2890603005/ by bmcquade@chromium.org. The reason for reverting is: Reverting based on findit-for-me notification.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2890503003/ by afakhry@chromium.org. The reason for reverting is: Causes the following browser_tests to fail on the Linux ChromiumOS Tests builder PageLoadMetricsBrowserTest.NonHtmlMainResource PageLoadMetricsBrowserTest.Ignore204Pages PageLoadMetricsBrowserTest.HttpErrorPage PageLoadMetricsBrowserTest.IgnoreDownloads BUG=723219. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
