Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2890483002: Revert of Add more virtual tests for off-main-thread-fetch (Closed)

Created:
3 years, 7 months ago by kolos(dont_use_it)
Modified:
3 years, 7 months ago
Reviewers:
falken, horo
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add more virtual tests for off-main-thread-fetch (patchset #5 id:80001 of https://codereview.chromium.org/2882383002/ ) Reason for revert: This CL probably causes test failures. See crbug.com/722838 Original issue's description: > Add more virtual tests for off-main-thread-fetch > > BUG=443374 > > Review-Url: https://codereview.chromium.org/2882383002 > Cr-Commit-Position: refs/heads/master@{#472047} > Committed: https://chromium.googlesource.com/chromium/src/+/01cef836909addbe68a475c633e6451e48ceab41 TBR=falken@chromium.org,horo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=443374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -126 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 6 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-mixed-content-to-inscope.https-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-mixed-content-to-outscope.https-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/foreign-fetch-workers.https-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/fetch/chromium/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/inspector/service-workers/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-cache-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-content-encoding-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-cors-preflight-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-redirect-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-xhr-fetch-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/security/cookies/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/security/cookies/third-party-cookie-blocking-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/serviceworker/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/serviceworker/chromium.performance-timeline-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/resource-timing-allow-origin-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/shared-worker-performance-timeline-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/worker-performance-timeline-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kolos(dont_use_it)
Created Revert of Add more virtual tests for off-main-thread-fetch
3 years, 7 months ago (2017-05-16 14:21:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890483002/1
3 years, 7 months ago (2017-05-16 14:21:41 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 14:21:44 UTC) #5
horo
On 2017/05/16 14:21:44, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 7 months ago (2017-05-16 14:26:15 UTC) #6
horo
On 2017/05/16 14:26:15, horo wrote: > On 2017/05/16 14:21:44, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-05-16 14:29:48 UTC) #7
horo
3 years, 7 months ago (2017-05-16 14:32:29 UTC) #8
On 2017/05/16 14:29:48, horo wrote:
> On 2017/05/16 14:26:15, horo wrote:
> > On 2017/05/16 14:21:44, commit-bot: I haz the power wrote:
> > > No L-G-T-M from a valid reviewer yet.
> > > CQ run can only be started once the patch has received an L-G-T-M from a
> full
> > > committer.
> > > Even if an L-G-T-M may have been provided, it was from a
non-committer,_not_
> a
> > > full super star committer.
> > > Committers are members of the group "project-chromium-committers".
> > > Note that this has nothing to do with OWNERS files.
> > 
> > Could you please wait a moment?
> > I will update third_party/WebKit/LayoutTests/LeakExpectations.
> 
> Created https://codereview.chromium.org/2889593002

Submitted
https://chromium.googlesource.com/chromium/src.git/+/8691cc8301afdcbf13422ebc...

Powered by Google App Engine
This is Rietveld 408576698