Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 2882383002: Add more virtual tests for off-main-thread-fetch (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more virtual tests for off-main-thread-fetch BUG=443374 Review-Url: https://codereview.chromium.org/2882383002 Cr-Commit-Position: refs/heads/master@{#472047} Committed: https://chromium.googlesource.com/chromium/src/+/01cef836909addbe68a475c633e6451e48ceab41

Patch Set 1 #

Patch Set 2 : add expected.txt #

Patch Set 3 : rebase #

Patch Set 4 : update NeverFixTests TestExpectations, and add http/tests/fetch/chromium #

Patch Set 5 : add http/tests/fetch/chromium/README.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 6 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-mixed-content-to-inscope.https-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-mixed-content-to-outscope.https-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/foreign-fetch-workers.https-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/fetch/chromium/README.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/inspector/service-workers/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-cache-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-content-encoding-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-cors-preflight-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-redirect-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/misc/resource-timing-sizes-xhr-fetch-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/security/cookies/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/security/cookies/third-party-cookie-blocking-worker-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/serviceworker/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/serviceworker/chromium.performance-timeline-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/README.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/resource-timing-allow-origin-expected.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/shared-worker-performance-timeline-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/workers/worker-performance-timeline-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (22 generated)
horo
falken@ Please review this.
3 years, 7 months ago (2017-05-16 04:10:47 UTC) #14
falken
lgtm
3 years, 7 months ago (2017-05-16 05:40:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882383002/60001
3 years, 7 months ago (2017-05-16 06:00:46 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/437956)
3 years, 7 months ago (2017-05-16 06:09:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882383002/80001
3 years, 7 months ago (2017-05-16 07:55:45 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/01cef836909addbe68a475c633e6451e48ceab41
3 years, 7 months ago (2017-05-16 09:15:36 UTC) #28
kolos(dont_use_it)
3 years, 7 months ago (2017-05-16 14:21:10 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2890483002/ by kolos@google.com.

The reason for reverting is: This CL probably causes test failures. See
crbug.com/722838.

Powered by Google App Engine
This is Rietveld 408576698