Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2890433002: Revert "Abandon user sign in when policy is retrieved before session started." (Closed)

Created:
3 years, 7 months ago by emaxx
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, hashimoto+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert "Abandon user sign in when policy is retrieved before session started." This reverts commit 1de6fb83edb4dccdfd53ee5db5ae8b6b59fb24dc. Reverting due to the broken compilation of Chrome: src/chromeos/dbus/session_manager_client.cc:118:36: error: no member named 'dbus_error' in namespace 'login_manager' This error is due to the DEPS roll of third_party/cros_system_api not being performed correctly. BUG=689206, 722558 https: //chromium.googlesource.com/chromium/src/+/1de6fb83edb4dccdfd53ee5db5ae8b6b59fb24dc Review-Url: https://codereview.chromium.org/2890433002 . Cr-Commit-Position: refs/branch-heads/3071@{#579} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e01786199637c46bf8d244afd7334280bbdcb62f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -407 lines) Patch
M chrome/browser/chromeos/policy/device_local_account_policy_store.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 3 chunks +4 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 9 chunks +12 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 5 chunks +7 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M chromeos/dbus/blocking_method_caller.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chromeos/dbus/blocking_method_caller.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M chromeos/dbus/blocking_method_caller_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.h View 1 chunk +5 lines, -8 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 2 chunks +12 lines, -26 lines 0 comments Download
M chromeos/dbus/mock_session_manager_client.h View 1 chunk +5 lines, -7 lines 0 comments Download
M chromeos/dbus/session_manager_client.h View 4 chunks +14 lines, -37 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 12 chunks +75 lines, -163 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
emaxx
3 years, 7 months ago (2017-05-16 12:31:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e01786199637c46bf8d244afd7334280bbdcb62f.

Powered by Google App Engine
This is Rietveld 408576698