Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2877503002: Abandon user sign in when policy is retrieved before session started. (Closed)

Created:
3 years, 7 months ago by emaxx
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Abandon user sign in when policy is retrieved before session started. If it happens that user policy is retrieved before session is started, then there's no policy to apply to the user which could be used as policy enforcement escape. This is a case when some flow went wrong, and we abandon the user sign in. BUG=689206 Review-Url: https://codereview.chromium.org/2801993002 Cr-Commit-Position: refs/heads/master@{#468000} (cherry picked from commit f305a94dd4908c4975db3444e6b80732f48dcb39) Review-Url: https://codereview.chromium.org/2877503002 . Cr-Commit-Position: refs/branch-heads/3071@{#502} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1de6fb83edb4dccdfd53ee5db5ae8b6b59fb24dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -170 lines) Patch
M chrome/browser/chromeos/policy/device_local_account_policy_store.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 3 chunks +28 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 9 chunks +22 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 5 chunks +17 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M chromeos/dbus/blocking_method_caller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chromeos/dbus/blocking_method_caller.cc View 4 chunks +15 lines, -8 lines 0 comments Download
M chromeos/dbus/blocking_method_caller_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.h View 1 chunk +8 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_session_manager_client.cc View 2 chunks +26 lines, -12 lines 0 comments Download
M chromeos/dbus/mock_session_manager_client.h View 1 chunk +7 lines, -5 lines 0 comments Download
M chromeos/dbus/session_manager_client.h View 4 chunks +37 lines, -14 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 12 chunks +163 lines, -75 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
emaxx
3 years, 7 months ago (2017-05-10 15:00:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1de6fb83edb4dccdfd53ee5db5ae8b6b59fb24dc.

Powered by Google App Engine
This is Rietveld 408576698