[Media controls] Integrate rotate-to-fullscreen with orientation lock

[Media controls] Integrate rotate-to-fullscreen with orientation lock

Until now, enabling the video-rotate-to-fullscreen feature required
disabling the video-fullscreen-orientation-lock feature. This patch
makes MediaControlsOrientationLockDelegate aware of
MediaControlsRotateToFullscreenDelegate, specifically when both are
enabled and the user hasn't locked their screen orientation it will only
lock the screen orientation until the user rotates their device to match
the orientation of the video (whereas previously it would hold the lock
until the video stopped being fullscreen). Thus the user will be able to
exit fullscreen by rotating their device back to the opposite
orientation.

The reason this only happens if the user hasn't locked their screen
orientation at the OS level is to make it possible to watch videos
whilst lying in bed with your head at 90 degrees to the usual up
direction.

To help visualize the maths behind the orientation calculations, I wrote
https://jsbin.com/sobopem and https://jsbin.com/rijakaf (view them on a
phone or tablet).

BUG=713225
Review-Url: https://codereview.chromium.org/2890423003
Cr-Commit-Position: refs/heads/master@{#474632}
Committed: https://chromium.googlesource.com/chromium/src/+/0dfadaecdbd95a4babb5b05a3fc50441b0aba845

[johnme, 2017-05-19 20:39:23]

johnme@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-05-24 17:03:41]

lgtm

https://codereview.chromium.org/2890423003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp
(right):

https://codereview.chromium.org/2890423003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp:74:
FakeWebScreenOrientationClient web_screen_orientation_client;
style: you are missing a _

[johnme, 2017-05-24 17:07:36]

johnme@chromium.org changed reviewers:
+ palmer@chromium.org

[johnme, 2017-05-24 17:07:37]

+palmer: please approve
device/screen_orientation/public/interfaces/screen_orientation.mojom - thanks!

[johnme, 2017-05-24 17:17:42]

https://codereview.chromium.org/2890423003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp
(right):

https://codereview.chromium.org/2890423003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp:74:
FakeWebScreenOrientationClient web_screen_orientation_client;
On 2017/05/24 17:03:41, mlamouri (OOO up to 23-05) wrote:
> style: you are missing a _

Done.

[palmer, 2017-05-24 18:18:55]

lgtm

[johnme, 2017-05-24 18:33:18]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-05-24 18:33:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2890423003/#ps40001
(title: "Fix tests and add underscore")

[commit-bot: I haz the power, 2017-05-24 18:34:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:39:41]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[johnme, 2017-05-24 18:51:37]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-05-24 18:51:38]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2890423003/#ps60001
(title: "Fix gn deps")

[commit-bot: I haz the power, 2017-05-24 18:52:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:15:56]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[johnme, 2017-05-25 00:46:07]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-05-25 00:46:08]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2890423003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-25 00:46:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 01:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 01:39:23]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[johnme, 2017-05-25 10:18:55]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-05-25 10:18:56]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2890423003/#ps100001
(title: "#undef atan2,fmod")

[commit-bot: I haz the power, 2017-05-25 10:19:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 12:40:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495707535542280,
"parent_rev": "6097e83a010c693bce494bb3b9ff5eb79fa252ac", "commit_rev":
"0dfadaecdbd95a4babb5b05a3fc50441b0aba845"}

[commit-bot: I haz the power, 2017-05-25 12:40:38]

Description was changed from

==========
[Media controls] Integrate rotate-to-fullscreen with orientation lock

Until now, enabling the video-rotate-to-fullscreen feature required
disabling the video-fullscreen-orientation-lock feature. This patch
makes MediaControlsOrientationLockDelegate aware of
MediaControlsRotateToFullscreenDelegate, specifically when both are
enabled and the user hasn't locked their screen orientation it will only
lock the screen orientation until the user rotates their device to match
the orientation of the video (whereas previously it would hold the lock
until the video stopped being fullscreen). Thus the user will be able to
exit fullscreen by rotating their device back to the opposite
orientation.

The reason this only happens if the user hasn't locked their screen
orientation at the OS level is to make it possible to watch videos
whilst lying in bed with your head at 90 degrees to the usual up
direction.

To help visualize the maths behind the orientation calculations, I wrote
https://jsbin.com/sobopem and https://jsbin.com/rijakaf (view them on a
phone or tablet).

BUG=713225
==========

to

==========
[Media controls] Integrate rotate-to-fullscreen with orientation lock

Until now, enabling the video-rotate-to-fullscreen feature required
disabling the video-fullscreen-orientation-lock feature. This patch
makes MediaControlsOrientationLockDelegate aware of
MediaControlsRotateToFullscreenDelegate, specifically when both are
enabled and the user hasn't locked their screen orientation it will only
lock the screen orientation until the user rotates their device to match
the orientation of the video (whereas previously it would hold the lock
until the video stopped being fullscreen). Thus the user will be able to
exit fullscreen by rotating their device back to the opposite
orientation.

The reason this only happens if the user hasn't locked their screen
orientation at the OS level is to make it possible to watch videos
whilst lying in bed with your head at 90 degrees to the usual up
direction.

To help visualize the maths behind the orientation calculations, I wrote
https://jsbin.com/sobopem and https://jsbin.com/rijakaf (view them on a
phone or tablet).

BUG=713225

Review-Url: https://codereview.chromium.org/2890423003
Cr-Commit-Position: refs/heads/master@{#474632}
Committed:
https://chromium.googlesource.com/chromium/src/+/0dfadaecdbd95a4babb5b05a3fc5...
==========

[commit-bot: I haz the power, 2017-05-25 12:40:39]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/0dfadaecdbd95a4babb5b05a3fc5...