third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp - Issue 2890423003: [Media controls] Integrate rotate-to-fullscreen with orientation lock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

Issue 2890423003: [Media controls] Integrate rotate-to-fullscreen with orientation lock (Closed)

Patch Set: #undef atan2,fmod Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp ('k') | third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

index 832dd94dd1d30b08411ba7f8671c624a3a5b9095..d91eea1f3829e940073b41036a2143f59a4674a1 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

@@ -188,8 +188,8 @@ class MediaControlsOrientationLockDelegateTest : public ::testing::Test {

}

bool DelegateWillUnlockFullscreen() const {

- return MediaControls()

- ->orientation_lock_delegate_->should_unlock_orientation_;

+ return MediaControls()->orientation_lock_delegate_->locked_orientation_ !=

+ kWebScreenOrientationLockDefault /* unlocked */;

}

WebScreenOrientationLockType ComputeOrientationLock() const {