Metrics for submission event when a user accepts save/update prompt.

Metrics for submission event when a user accepts save/update prompt.

On CL https://codereview.chromium.org/2859243004/ it was implemented a UMA metric for heuristics that was used for detecting a form submission in case when this submission was considered to be successful. This CL adds metric subbmission heuristics when the user accepts save/update prompt. So we can understand which submission heuristic is best, and probably which of them are useless.

BUG=None

Review-Url: https://codereview.chromium.org/2890423002
Cr-Commit-Position: refs/heads/master@{#473543}
Committed: https://chromium.googlesource.com/chromium/src/+/f8c5824267cdbcb81a45de00e4a8a741cc5f9247

[dvadym, 2017-05-19 12:11:46]

Description was changed from

==========
Imple

BUG=None
==========

to

==========
Metrics for submission event when a user accepts save/update prompt.

On CL https://codereview.chromium.org/2859243004/ it was implemented a UMA
metric for heuristics that was used for detecting a form submission in case when
this submission was considered to be successful. This CL adds metric subbmission
heuristics when the user accepts save/update prompt. So we can understand which
submission heuristic is best, and probably which of them are useless.

BUG=None
==========

[dvadym, 2017-05-19 12:11:46]

dvadym@chromium.org changed reviewers:
+ vasilii@chromium.org

[dvadym, 2017-05-19 12:12:33]

Hi Vasilii,

could you please review this CL?

Regards,
Vadym

[vasilii, 2017-05-19 12:15:53]

lgtm

[dvadym, 2017-05-19 12:19:59]

dvadym@chromium.org changed reviewers:
+ isherman@chromium.org

[dvadym, 2017-05-19 12:19:59]

Hi Ilya,

could you please review histograms.xml?

Regards,
Vadym

[Ilya Sherman, 2017-05-19 21:11:16]

Metrics LGTM % nits:

https://codereview.chromium.org/2890423002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2890423002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:49317: +    form submission for save or
update a password. Recorded each time when by a
nit: s/for save or update/when saving or updating

https://codereview.chromium.org/2890423002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:49317: +    form submission for save or
update a password. Recorded each time when by a
nit: s/each time when by/each time

[dvadym, 2017-05-22 08:57:10]

Thanks for review Ilya!

https://codereview.chromium.org/2890423002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2890423002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:49317: +    form submission for save or
update a password. Recorded each time when by a
On 2017/05/19 21:11:16, Ilya Sherman wrote:
> nit: s/each time when by/each time

Done.

https://codereview.chromium.org/2890423002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:49317: +    form submission for save or
update a password. Recorded each time when by a
On 2017/05/19 21:11:16, Ilya Sherman wrote:
> nit: s/for save or update/when saving or updating

Done.

[dvadym, 2017-05-22 08:57:21]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2017-05-22 08:57:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
vasilii@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2890423002/#ps20001
(title: "Comments addressed")

[commit-bot: I haz the power, 2017-05-22 08:57:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 10:36:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495443441538670,
"parent_rev": "98ee4f50a33d157cddb3a27a9a62421da3ead010", "commit_rev":
"f8c5824267cdbcb81a45de00e4a8a741cc5f9247"}

[commit-bot: I haz the power, 2017-05-22 10:36:57]

Description was changed from

==========
Metrics for submission event when a user accepts save/update prompt.

On CL https://codereview.chromium.org/2859243004/ it was implemented a UMA
metric for heuristics that was used for detecting a form submission in case when
this submission was considered to be successful. This CL adds metric subbmission
heuristics when the user accepts save/update prompt. So we can understand which
submission heuristic is best, and probably which of them are useless.

BUG=None
==========

to

==========
Metrics for submission event when a user accepts save/update prompt.

On CL https://codereview.chromium.org/2859243004/ it was implemented a UMA
metric for heuristics that was used for detecting a form submission in case when
this submission was considered to be successful. This CL adds metric subbmission
heuristics when the user accepts save/update prompt. So we can understand which
submission heuristic is best, and probably which of them are useless.

BUG=None

Review-Url: https://codereview.chromium.org/2890423002
Cr-Commit-Position: refs/heads/master@{#473543}
Committed:
https://chromium.googlesource.com/chromium/src/+/f8c5824267cdbcb81a45de00e4a8...
==========

[commit-bot: I haz the power, 2017-05-22 10:36:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8c5824267cdbcb81a45de00e4a8...