Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2890423002: Metrics for submission event when a user accepts save/update prompt. (Closed)
Patch Set: Comments addressed Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_metrics_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index eb88be67ab7c5ccd1a549ad592c423236fc4d6b3..bed0ff943bf19b79bd4a71629daafe6ab655341c 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -419,6 +419,9 @@ void PasswordFormManager::Save() {
DCHECK_EQ(FormFetcher::State::NOT_WAITING, form_fetcher_->GetState());
DCHECK(!client_->IsIncognito());
+ metrics_util::LogPasswordAcceptedSaveUpdateSubmissionIndicatorEvent(
+ submitted_form_->submission_event);
+
if ((user_action_ == kUserActionNone) &&
DidPreferenceChange(best_matches_, pending_credentials_.username_value)) {
SetUserAction(kUserActionChoose);
@@ -451,6 +454,8 @@ void PasswordFormManager::Save() {
void PasswordFormManager::Update(
const autofill::PasswordForm& credentials_to_update) {
+ metrics_util::LogPasswordAcceptedSaveUpdateSubmissionIndicatorEvent(
+ submitted_form_->submission_event);
if (observed_form_.IsPossibleChangePasswordForm()) {
FormStructure form_structure(credentials_to_update.form_data);
UploadPasswordVote(observed_form_, autofill::NEW_PASSWORD,
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_metrics_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698