Change PRESUBMIT warning text for obsolete predeclaration

Change PRESUBMIT warning text for obsolete predeclaration

When a patch removes the code that required a predeclaration the PRESUBMIT would
print a warning with a message like "ResourceRequestInfo forward declaration is
becoming useless". I didn't understand the meaning of the message.

Change the message to "ResourceRequestInfo forward declaration is no longer
needed" which hopefully will be easier to understand.

BUG=662195
Review-Url: https://codereview.chromium.org/2890413002
Cr-Commit-Position: refs/heads/master@{#473169}
Committed: https://chromium.googlesource.com/chromium/src/+/6416dea8ddbbd7a285da9ea31bb1a223d91f09c2

[Adam Rice, 2017-05-19 10:57:42]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 10:58:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-05-19 10:59:10]

ricea@chromium.org changed reviewers:
+ jbriance@cisco.com

[commit-bot: I haz the power, 2017-05-19 11:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 11:10:11]

Dry run: This issue passed the CQ dry run.

[jbriance, 2017-05-19 11:27:00]

I was not a huge fan of this sentence either, LGTM :)

[jbriance, 2017-05-19 11:28:09]

One comment though, maybe you can link this CL to bug 662195
(https://bugs.chromium.org/p/chromium/issues/detail?id=662195)

[Adam Rice, 2017-05-19 11:29:22]

ricea@chromium.org changed reviewers:
+ jochen@chromium.org

[Adam Rice, 2017-05-19 11:29:23]

+jochen for OWNERS.

[Adam Rice, 2017-05-19 11:31:09]

Description was changed from

==========
Change PRESUBMIT warning text for obsolete predeclaration

When a patch removes the code that required a predeclaration the PRESUBMIT would
print a warning with a message like "ResourceRequestInfo forward declaration is
becoming useless". I didn't understand the meaning of the message.

Change the message to "ResourceRequestInfo forward declaration is no longer
needed" which hopefully will be easier to understand.

BUG=
==========

to

==========
Change PRESUBMIT warning text for obsolete predeclaration

When a patch removes the code that required a predeclaration the PRESUBMIT would
print a warning with a message like "ResourceRequestInfo forward declaration is
becoming useless". I didn't understand the meaning of the message.

Change the message to "ResourceRequestInfo forward declaration is no longer
needed" which hopefully will be easier to understand.

BUG=662195
==========

[Adam Rice, 2017-05-19 11:31:21]

On 2017/05/19 11:28:09, jbriance wrote:
> One comment though, maybe you can link this CL to bug 662195
> (https://bugs.chromium.org/p/chromium/issues/detail?id=662195)

Thanks, done.

[jochen (gone - plz use gerrit), 2017-05-19 12:17:23]

lgtm

[Adam Rice, 2017-05-19 12:33:52]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2017-05-19 12:34:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 12:39:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495197232498580, "parent_rev":
"5fcdbcd466008a0669c1c1e9bcb77ae69010639e", "commit_rev":
"6416dea8ddbbd7a285da9ea31bb1a223d91f09c2"}

[commit-bot: I haz the power, 2017-05-19 12:39:38]

Description was changed from

==========
Change PRESUBMIT warning text for obsolete predeclaration

When a patch removes the code that required a predeclaration the PRESUBMIT would
print a warning with a message like "ResourceRequestInfo forward declaration is
becoming useless". I didn't understand the meaning of the message.

Change the message to "ResourceRequestInfo forward declaration is no longer
needed" which hopefully will be easier to understand.

BUG=662195
==========

to

==========
Change PRESUBMIT warning text for obsolete predeclaration

When a patch removes the code that required a predeclaration the PRESUBMIT would
print a warning with a message like "ResourceRequestInfo forward declaration is
becoming useless". I didn't understand the meaning of the message.

Change the message to "ResourceRequestInfo forward declaration is no longer
needed" which hopefully will be easier to understand.

BUG=662195

Review-Url: https://codereview.chromium.org/2890413002
Cr-Commit-Position: refs/heads/master@{#473169}
Committed:
https://chromium.googlesource.com/chromium/src/+/6416dea8ddbbd7a285da9ea31bb1...
==========

[commit-bot: I haz the power, 2017-05-19 12:39:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6416dea8ddbbd7a285da9ea31bb1...