PRESUBMIT.py - Issue 2890413002: Change PRESUBMIT warning text for obsolete predeclaration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2890413002: Change PRESUBMIT warning text for obsolete predeclaration (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index a32035426b498e53b62f927050b27b0f64f925ef..d9777e0f35c1575c566b675b4d482d010ee9e617 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1732,7 +1732,7 @@ def _CheckUselessForwardDeclarations(input_api, output_api):

for decl in useless_fwd_decls:

if input_api.re.search(r'\b%s\b' % decl, line[1:]):

results.append(output_api.PresubmitPromptWarning(

- '%s: %s forward declaration is becoming useless' %

+ '%s: %s forward declaration is no longer needed' %

(f.LocalPath(), decl)))

useless_fwd_decls.remove(decl)

« no previous file with comments | « no previous file | no next file » | no next file with comments »