Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 289023002: Initial SIMD demos life and earth for PNaCl. (Closed)

Created:
6 years, 7 months ago by nfullagar1
Modified:
6 years, 7 months ago
Reviewers:
nfullagar, binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

Initial SIMD demos life and earth for PNaCl. The Life SIMD demo exercises 16 element fixed point vectors to operate on 16 cells at a time. The Earth SIMD demo uses a mix of 4 element single precision floating point and a small amount of fixed point SIMD. At the moment, both demos do not exhibit much speedup from using SIMD, but this should improve as the quality of PNaCl's code generation gets better. Also, fix an issue where dragging a slider wasn't continuously updating in the regular voronoi & earth demos. R=binji@chromium.org BUG=http://code.google.com/p/nativeclient/issues/detail?id=2205 TEST=demo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270916

Patch Set 1 #

Total comments: 10

Patch Set 2 : added alignment to life_simd #

Patch Set 3 : title #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -176 lines) Patch
M native_client_sdk/src/build_tools/build_projects.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/examples/demo/earth/earth.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/earth/example.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/demo/earth_simd/earth.cc View 1 8 chunks +118 lines, -78 lines 0 comments Download
A + native_client_sdk/src/examples/demo/earth_simd/earth.jpg View Binary file 0 comments Download
A + native_client_sdk/src/examples/demo/earth_simd/earthnight.jpg View Binary file 0 comments Download
A + native_client_sdk/src/examples/demo/earth_simd/example.dsc View 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/examples/demo/earth_simd/example.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/demo/earth_simd/index.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/life/life.c View 3 chunks +28 lines, -29 lines 0 comments Download
A + native_client_sdk/src/examples/demo/life_simd/example.dsc View 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/examples/demo/life_simd/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/demo/life_simd/life.c View 1 6 chunks +184 lines, -54 lines 0 comments Download
M native_client_sdk/src/examples/demo/voronoi/example.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
nfullagar1
6 years, 7 months ago (2014-05-15 17:12:33 UTC) #1
binji
lgtm https://codereview.chromium.org/289023002/diff/1/native_client_sdk/src/examples/demo/earth_simd/earth.cc File native_client_sdk/src/examples/demo/earth_simd/earth.cc (left): https://codereview.chromium.org/289023002/diff/1/native_client_sdk/src/examples/demo/earth_simd/earth.cc#oldcode477 native_client_sdk/src/examples/demo/earth_simd/earth.cc:477: float ipr = 1.0f - pr; You don't ...
6 years, 7 months ago (2014-05-15 18:58:36 UTC) #2
nfullagar
thx Added some more explicit alignment to simd life's cell in & out buffers (although ...
6 years, 7 months ago (2014-05-15 21:25:13 UTC) #3
binji
lgtm
6 years, 7 months ago (2014-05-15 21:38:25 UTC) #4
nfullagar
The CQ bit was checked by nfullagar@google.com
6 years, 7 months ago (2014-05-15 23:32:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@chromium.org/289023002/40001
6 years, 7 months ago (2014-05-15 23:34:38 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 02:18:18 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 03:20:22 UTC) #8
Message was sent while issue was closed.
Change committed as 270916

Powered by Google App Engine
This is Rietveld 408576698