Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2890013002: LayoutMenuList::ControlClipRect may depend on size of children (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
wangxianzhu
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

LayoutMenuList::ControlClipRect may depend on size of children Add NeedsPaintPropertyUpdate(). BUG=721249 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=wangxianzhu NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2874413003 Cr-Original-Commit-Position: refs/heads/master@{#471828} Review-Url: https://codereview.chromium.org/2890013002 Cr-Commit-Position: refs/branch-heads/3071@{#600} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/29d64645baf8815aa1d709165bf2586b8f4ad0eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890013002/1
3 years, 7 months ago (2017-05-17 16:26:17 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 16:28:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29d64645baf8815aa1d709165bf2...

Powered by Google App Engine
This is Rietveld 408576698