Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp

Issue 2890013002: LayoutMenuList::ControlClipRect may depend on size of children (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
index 9fdb15784eac0ec38aeca66984bdacdcc310d5f1..6f3548afb875f1d328e8d5e7af6c72c89d9b47cd 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "core/html/HTMLIFrameElement.h"
+#include "core/html/HTMLSelectElement.h"
#include "core/paint/PaintPropertyTreeBuilderTest.h"
#include "core/paint/PaintPropertyTreePrinter.h"
@@ -751,4 +752,20 @@ TEST_P(PaintPropertyTreeUpdateTest, Preserve3DChange) {
EXPECT_FALSE(transform->FlattensInheritedTransform());
}
+TEST_P(PaintPropertyTreeUpdateTest, MenuListControlClipChange) {
+ SetBodyInnerHTML(
+ "<select id='select' style='white-space: normal'>"
+ " <option></option>"
+ " <option>bar</option>"
+ "</select>");
+
+ auto* select = GetLayoutObjectByElementId("select");
+ EXPECT_NE(nullptr, select->PaintProperties()->OverflowClip());
+
+ // Should not assert in FindPropertiesNeedingUpdate.
+ toHTMLSelectElement(select->GetNode())->setSelectedIndex(1);
+ GetDocument().View()->UpdateAllLifecyclePhases();
+ EXPECT_NE(nullptr, select->PaintProperties()->OverflowClip());
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMenuList.cpp ('k') | third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698