Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2890003002: [ObjC ARC] Converts ios/chrome/browser/web:eg_tests to ARC. (Closed)

Created:
3 years, 7 months ago by baxley
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), stkhapugin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/web:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2890003002 Cr-Commit-Position: refs/heads/master@{#472517} Committed: https://chromium.googlesource.com/chromium/src/+/108d7013f655111f9e528bd8b8161ee58a54914f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -19 lines) Patch
M ios/chrome/browser/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web/browsing_egtest.mm View 3 chunks +8 lines, -4 lines 0 comments Download
M ios/chrome/browser/web/browsing_prevent_default_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/cache_egtest.mm View 4 chunks +8 lines, -5 lines 0 comments Download
M ios/chrome/browser/web/child_window_open_by_dom_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/forms_egtest.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/web/http_auth_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/js_print_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/navigation_egtest.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/web/progress_indicator_egtest.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/stop_loading_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/visible_url_egtest.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/web/window_open_by_dom_egtest.mm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
baxley
3 years, 7 months ago (2017-05-17 17:08:34 UTC) #4
baxley
3 years, 7 months ago (2017-05-17 17:08:44 UTC) #5
Eugene But (OOO till 7-30)
lgtm
3 years, 7 months ago (2017-05-17 18:32:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890003002/1
3 years, 7 months ago (2017-05-17 18:41:32 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 19:01:45 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/108d7013f655111f9e528bd8b816...

Powered by Google App Engine
This is Rietveld 408576698