Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: ios/chrome/browser/web/browsing_egtest.mm

Issue 2890003002: [ObjC ARC] Converts ios/chrome/browser/web:eg_tests to ARC. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/web/BUILD.gn ('k') | ios/chrome/browser/web/browsing_prevent_default_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/browsing_egtest.mm
diff --git a/ios/chrome/browser/web/browsing_egtest.mm b/ios/chrome/browser/web/browsing_egtest.mm
index dbf7d60b582e9904e4e5209c01178ea8ecbecc56..534ee43f89de60170fd54e2609a3435f4c81ea1e 100644
--- a/ios/chrome/browser/web/browsing_egtest.mm
+++ b/ios/chrome/browser/web/browsing_egtest.mm
@@ -35,6 +35,10 @@
#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
using chrome_test_util::OmniboxText;
using chrome_test_util::WebViewContainingText;
@@ -383,8 +387,8 @@ id<GREYMatcher> GoButtonMatcher() {
// TODO(crbug.com/638674): Evaluate if this can move to shared code
// Navigates back to the previous webpage.
- (void)goBack {
- base::scoped_nsobject<GenericChromeCommand> backCommand(
- [[GenericChromeCommand alloc] initWithTag:IDC_BACK]);
+ GenericChromeCommand* backCommand =
+ [[GenericChromeCommand alloc] initWithTag:IDC_BACK];
chrome_test_util::RunCommandWithActiveViewController(backCommand);
[ChromeEarlGrey waitForPageToFinishLoading];
@@ -393,8 +397,8 @@ id<GREYMatcher> GoButtonMatcher() {
// Navigates forward to a previous webpage.
// TODO(crbug.com/638674): Evaluate if this can move to shared code
- (void)goForward {
- base::scoped_nsobject<GenericChromeCommand> forwardCommand(
- [[GenericChromeCommand alloc] initWithTag:IDC_FORWARD]);
+ GenericChromeCommand* forwardCommand =
+ [[GenericChromeCommand alloc] initWithTag:IDC_FORWARD];
chrome_test_util::RunCommandWithActiveViewController(forwardCommand);
[ChromeEarlGrey waitForPageToFinishLoading];
« no previous file with comments | « ios/chrome/browser/web/BUILD.gn ('k') | ios/chrome/browser/web/browsing_prevent_default_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698