Enable print as image by default

Enable print as image by default

Enable the print as image flag by default so that print as image is
available by default on Linux/ChromeOS.

BUG=675798
Review-Url: https://codereview.chromium.org/2889883002
Cr-Commit-Position: refs/heads/master@{#473295}
Committed: https://chromium.googlesource.com/chromium/src/+/c51ee3623f7ebea04867980986d1e7226d5fefb0

[rbpotter, 2017-05-17 01:32:46]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[rbpotter, 2017-05-17 01:34:27]

Description was changed from

==========
Enable print as image by default

Enable the print as image flag by default so that print as image is
available by default on Linux/ChromeOS.

BUG=675798
==========

to

==========
Enable print as image by default

Enable the print as image flag by default so that print as image is
available by default on Linux/ChromeOS.

BUG=675798
==========

[rbpotter, 2017-05-17 01:34:28]

rbpotter@chromium.org changed reviewers:
+ dpapad@chromium.org, thestig@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:35:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:24:54]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-05-17 08:02:42]

lgtm

[dpapad, 2017-05-17 16:35:58]

https://codereview.chromium.org/2889883002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2889883002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:284: base::FEATURE_ENABLED_BY_DEFAULT};
Isn't this enabling by default the feature on all platforms, not just ChromeOS
and Linux? Just checking whether this is intentional, since the CL description
only mentions ChromeOS and Linux.

[rbpotter, 2017-05-17 16:54:32]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[rbpotter, 2017-05-17 16:55:09]

https://codereview.chromium.org/2889883002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2889883002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:284: base::FEATURE_ENABLED_BY_DEFAULT};
On 2017/05/17 16:35:58, dpapad wrote:
> Isn't this enabling by default the feature on all platforms, not just ChromeOS
> and Linux? Just checking whether this is intentional, since the CL description
> only mentions ChromeOS and Linux.

Good catch, thanks. Thought I had if defs around this to remove it for
Mac and Win, but apparently not. Added them in new patchset.

[commit-bot: I haz the power, 2017-05-17 16:55:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 17:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:13:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dpapad, 2017-05-17 17:32:37]

https://codereview.chromium.org/2889883002/diff/40001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2889883002/diff/40001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:287: #if BUILDFLAG(ENABLE_PRINT_PREVIEW) &&
!defined(OS_WIN) && !defined(OS_MACOSX)
Probably need something as follows to fix  compilation errors on Mac and Win.

#if BUILDFLAG(ENABLE_PRINT_PREVIEW)

# if defined(OS_WIN) || defined(OS_MACOSX)
const base::Feature kPrintPdfAsImage{"PrintPdfAsImage", 
FEATURE_DISABLED_BY_DEFAULT};
#else
const base::Feature kPrintPdfAsImage{"PrintPdfAsImage", 
FEATURE_ENABLED_BY_DEFAULT};
#endif

#endif

[rbpotter, 2017-05-17 18:07:18]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:08:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-05-17 19:17:26]

https://codereview.chromium.org/2889883002/diff/40001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2889883002/diff/40001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:287: #if BUILDFLAG(ENABLE_PRINT_PREVIEW) &&
!defined(OS_WIN) && !defined(OS_MACOSX)
On 2017/05/17 17:32:37, dpapad wrote:
> Probably need something as follows to fix  compilation errors on Mac and Win.
> 
> #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
> 
> # if defined(OS_WIN) || defined(OS_MACOSX)
> const base::Feature kPrintPdfAsImage{"PrintPdfAsImage", 
> FEATURE_DISABLED_BY_DEFAULT};
> #else
> const base::Feature kPrintPdfAsImage{"PrintPdfAsImage", 
> FEATURE_ENABLED_BY_DEFAULT};
> #endif
> 
> #endif

I think it would be better if this feature just isn't defined
for Mac and Win at all, since the intent is for it not to exist
on those platforms. Have updated the other files where this was
referenced to reflect that.

[Lei Zhang, 2017-05-17 19:18:11]

looks better to me.

[commit-bot: I haz the power, 2017-05-17 20:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:07:10]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dpapad, 2017-05-17 21:14:35]

LGTM

[rbpotter, 2017-05-17 23:30:28]

The CQ bit was checked by rbpotter@chromium.org

[rbpotter, 2017-05-17 23:30:28]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2889883002/#ps60001
(title: "Fix mac and win compile errors")

[commit-bot: I haz the power, 2017-05-17 23:31:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 23:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:50:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rbpotter, 2017-05-17 23:58:08]

Patchset #5 (id:80001) has been deleted

[rbpotter, 2017-05-17 23:58:14]

The CQ bit was checked by rbpotter@chromium.org

[rbpotter, 2017-05-17 23:58:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2889883002/#ps100001
(title: "Fix JS style guide issue")

[commit-bot: I haz the power, 2017-05-18 00:00:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 01:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:41:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rbpotter, 2017-05-18 17:32:36]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2017-05-18 17:34:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 22:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:35:43]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rbpotter, 2017-05-19 17:54:22]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2017-05-19 17:55:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 20:25:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495216462149380,
"parent_rev": "f7f0f1c1aae1bfc819afddb0024d14af0d3c8ff4", "commit_rev":
"c51ee3623f7ebea04867980986d1e7226d5fefb0"}

[commit-bot: I haz the power, 2017-05-19 20:25:16]

Description was changed from

==========
Enable print as image by default

Enable the print as image flag by default so that print as image is
available by default on Linux/ChromeOS.

BUG=675798
==========

to

==========
Enable print as image by default

Enable the print as image flag by default so that print as image is
available by default on Linux/ChromeOS.

BUG=675798

Review-Url: https://codereview.chromium.org/2889883002
Cr-Commit-Position: refs/heads/master@{#473295}
Committed:
https://chromium.googlesource.com/chromium/src/+/c51ee3623f7ebea04867980986d1...
==========

[commit-bot: I haz the power, 2017-05-19 20:25:18]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c51ee3623f7ebea04867980986d1...