Enable print as image by default

chrome/common/chrome_features.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_features.h"
 
 #include "base/command_line.h"
 #include "chrome/common/chrome_switches.h"
 #include "extensions/features/features.h"
 #include "ppapi/features/features.h"
@@ skipping 266 matching lines @@
 const base::Feature kPrefService{"PrefService",
                                  base::FEATURE_DISABLED_BY_DEFAULT};
 
 #if defined(OS_CHROMEOS)
 // The lock screen will be preloaded so it is instantly available when the user
 // locks the Chromebook device.
 const base::Feature kPreloadLockScreen{"PreloadLockScreen",
                                        base::FEATURE_ENABLED_BY_DEFAULT};
 #endif
 
-#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
+#if BUILDFLAG(ENABLE_PRINT_PREVIEW) && !defined(OS_WIN) && !defined(OS_MACOSX)

[dpapad, 2017/05/17 17:32:37]

Probably need something as follows to fix  compilation errors on Mac and Win.

#if BUILDFLAG(ENABLE_PRINT_PREVIEW)

# if defined(OS_WIN) || defined(OS_MACOSX)
const base::Feature kPrintPdfAsImage{"PrintPdfAsImage", 
FEATURE_DISABLED_BY_DEFAULT};
#else
const base::Feature kPrintPdfAsImage{"PrintPdfAsImage", 
FEATURE_ENABLED_BY_DEFAULT};
#endif

#endif

[rbpotter, 2017/05/17 19:17:26]

I think it would be better if this feature just isn't defined
for Mac and Win at all, since the intent is for it not to exist
on those platforms. Have updated the other files where this was
referenced to reflect that.

 // Enables the Print as Image feature in print preview.
 const base::Feature kPrintPdfAsImage{"PrintPdfAsImage",
-                                     base::FEATURE_DISABLED_BY_DEFAULT};
+                                     base::FEATURE_ENABLED_BY_DEFAULT};
 #endif
 
 // Enables or disables push subscriptions keeping Chrome running in the
 // background when closed.
 const base::Feature kPushMessagingBackgroundMode{
     "PushMessagingBackgroundMode", base::FEATURE_DISABLED_BY_DEFAULT};
 
 #if defined(OS_CHROMEOS)
 // Runtime flag that indicates whether this leak detector should be enabled in
 // the current instance of Chrome.
@@ skipping 76 matching lines @@
   return base::FeatureList::IsEnabled(features::kPrefService) ||
 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
          base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
              switches::kMusConfig) == switches::kMash;
 #else
          false;
 #endif
 }
 
 }  // namespace features