Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2889843002: Settings: Network: Handle getmanagerProperties error correctly (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Network: Handle getmanagerProperties error correctly BUG=722977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation R=tbarzic@chromium.org Review-Url: https://codereview.chromium.org/2889843002 . Cr-Commit-Position: refs/heads/master@{#472925} Committed: https://chromium.googlesource.com/chromium/src/+/03bdb1e2d10e25f51ef62653fc3bff4c3e27e08c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
stevenjb
3 years, 7 months ago (2017-05-16 23:10:25 UTC) #3
tbarzic
lgtm
3 years, 7 months ago (2017-05-17 00:11:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889843002/1
3 years, 7 months ago (2017-05-17 15:52:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429255)
3 years, 7 months ago (2017-05-17 19:25:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889843002/1
3 years, 7 months ago (2017-05-17 22:28:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429885)
3 years, 7 months ago (2017-05-18 05:31:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889843002/1
3 years, 7 months ago (2017-05-18 15:45:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/430631)
3 years, 7 months ago (2017-05-18 20:50:28 UTC) #16
stevenjb
3 years, 7 months ago (2017-05-18 20:55:36 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03bdb1e2d10e25f51ef62653fc3bff4c3e27e08c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698