Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Issue 2889843002: Settings: Network: Handle getmanagerProperties error correctly (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
index 16e3b9e93b8f81464ad0bcd284068908e39e341a..839f41377e15059bfbb94411ddb383d1ddf2a389 100644
--- a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
@@ -154,6 +154,11 @@ Polymer({
// preferable to initiating a query for every known network at load time.
this.networkingPrivate.getManagedProperties(
this.selectedGuid_, function(properties) {
+ if (chrome.runtime.lastError || !properties) {
+ this.showAddPreferred_ = false;
+ this.showRemovePreferred_ = false;
+ return;
+ }
var preferred = button.hasAttribute('preferred');
if (this.isNetworkPolicyEnforced(properties.Priority)) {
this.showAddPreferred_ = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698