|
|
Created:
3 years, 7 months ago by chrishtr Modified:
3 years, 7 months ago CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, fmalita+watch_chromium.org, fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionOnly allow subsequence caching for SVG documents, not inline SVG.
Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076.
BUG=723076, 719835
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2889783003
Cr-Commit-Position: refs/heads/master@{#472704}
Committed: https://chromium.googlesource.com/chromium/src/+/c17fd462aca8510e9dc38bda911efa2b12d09d4e
Patch Set 1 #Patch Set 2 : none #
Total comments: 4
Patch Set 3 : none #Patch Set 4 : Merge branch 'master' into fixsvg #
Messages
Total messages: 40 (23 generated)
Description was changed from ========== none none BUG= ========== to ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only allow subsequence caching for SVG documents, not regular SVG. Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076. BUG=723076 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
chrishtr@chromium.org changed reviewers: + wangxianzhu@chromium.org
Description was changed from ========== Only allow subsequence caching for SVG documents, not regular SVG. Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076. BUG=723076 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only allow subsequence caching for SVG documents, not regular SVG. Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076. BUG=723076,719835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
lgtm
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2889783003/#ps20001 (title: "none")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
fs@opera.com changed reviewers: + fs@opera.com
Please s/regular/inline/ in subject and description ("regular" is a bit too devoid of meaning.) https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/svg/graphics/SVGImage.h (right): https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/svg/graphics/SVGImage.h:186: Page* GetPage() { return page_; } Nit: GetPageForTesting to avoid given people wrong ideas. https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp (right): https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp:157: LayoutObject* svg_root = local_frame->View()->GetLayoutView()->ChildAt(0); Nit: s/ChildAt(0)/FirstChild/ (ChildAt is quite the oddity, and we should probably avoid adding new uses of it... even more so when they are this trivial)
Description was changed from ========== Only allow subsequence caching for SVG documents, not regular SVG. Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076. BUG=723076,719835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only allow subsequence caching for SVG documents, not inline SVG. Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076. BUG=723076,719835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/svg/graphics/SVGImage.h (right): https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/svg/graphics/SVGImage.h:186: Page* GetPage() { return page_; } On 2017/05/17 at 11:14:45, fs wrote: > Nit: GetPageForTesting to avoid given people wrong ideas. Done. https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp (right): https://codereview.chromium.org/2889783003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp:157: LayoutObject* svg_root = local_frame->View()->GetLayoutView()->ChildAt(0); On 2017/05/17 at 11:14:45, fs wrote: > Nit: s/ChildAt(0)/FirstChild/ (ChildAt is quite the oddity, and we should probably avoid adding new uses of it... even more so when they are this trivial) Done.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2889783003/#ps40001 (title: "none")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2889783003/#ps60001 (title: "Merge branch 'master' into fixsvg")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495070248860240, "parent_rev": "e006aee237d27eb7dbefae03551121dbad59dcae", "commit_rev": "c17fd462aca8510e9dc38bda911efa2b12d09d4e"}
Message was sent while issue was closed.
Description was changed from ========== Only allow subsequence caching for SVG documents, not inline SVG. Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076. BUG=723076,719835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Only allow subsequence caching for SVG documents, not inline SVG. Once SVGRoots induce stacking contexts, we can do all SVG. See issue 723076. BUG=723076,719835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2889783003 Cr-Commit-Position: refs/heads/master@{#472704} Committed: https://chromium.googlesource.com/chromium/src/+/c17fd462aca8510e9dc38bda911e... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c17fd462aca8510e9dc38bda911e... |