Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2889633002: Revert of Disable flaky DestructiveScriptTest.MacrotaskRemoval (Closed)

Created:
3 years, 7 months ago by Bryan McQuade
Modified:
3 years, 7 months ago
Reviewers:
kolos1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky DestructiveScriptTest.MacrotaskRemoval (patchset #1 id:1 of https://codereview.chromium.org/2887683002/ ) Reason for revert: Revert https://codereview.chromium.org/2885773002/ should address the flake, so this test can now be re-enabled. Original issue's description: > Disable flaky DestructiveScriptTest.MacrotaskRemoval > > TBR=jochen@chromium.org,zhenw@chromium.org > BUG=722703 > > Review-Url: https://codereview.chromium.org/2887683002 > Cr-Commit-Position: refs/heads/master@{#472103} > Committed: https://chromium.googlesource.com/chromium/src/+/28e83a520012c28bb95b0b41cac7a03071001a4f TBR=kolos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=722703 Review-Url: https://codereview.chromium.org/2889633002 Cr-Commit-Position: refs/heads/master@{#472123} Committed: https://chromium.googlesource.com/chromium/src/+/e56b2dd082428125bac359c3511a2912d5ca3229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/execute_script_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bryan McQuade
Created Revert of Disable flaky DestructiveScriptTest.MacrotaskRemoval
3 years, 7 months ago (2017-05-16 16:10:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889633002/1
3 years, 7 months ago (2017-05-16 16:10:59 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 16:12:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e56b2dd082428125bac359c3511a...

Powered by Google App Engine
This is Rietveld 408576698