Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2887683002: Disable flaky DestructiveScriptTest.MacrotaskRemoval (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky DestructiveScriptTest.MacrotaskRemoval TBR=jochen@chromium.org,zhenw@chromium.org BUG=722703 Review-Url: https://codereview.chromium.org/2887683002 Cr-Commit-Position: refs/heads/master@{#472103} Committed: https://chromium.googlesource.com/chromium/src/+/28e83a520012c28bb95b0b41cac7a03071001a4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/execute_script_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887683002/1
3 years, 7 months ago (2017-05-16 12:05:35 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 12:05:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887683002/1
3 years, 7 months ago (2017-05-16 12:13:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/445691)
3 years, 7 months ago (2017-05-16 13:18:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887683002/1
3 years, 7 months ago (2017-05-16 14:24:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/28e83a520012c28bb95b0b41cac7a03071001a4f
3 years, 7 months ago (2017-05-16 14:52:02 UTC) #15
Bryan McQuade
3 years, 7 months ago (2017-05-16 16:10:17 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2889633002/ by bmcquade@chromium.org.

The reason for reverting is: Revert https://codereview.chromium.org/2885773002/
should address the flake, so this test can now be re-enabled..

Powered by Google App Engine
This is Rietveld 408576698