Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2889563002: Photo Picker dialog: Fix single-selection bug. (Closed)

Created:
3 years, 7 months ago by Finnur
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker dialog: Fix single-selection bug. BUG=656015 Review-Url: https://codereview.chromium.org/2889563002 Cr-Commit-Position: refs/heads/master@{#472119} Committed: https://chromium.googlesource.com/chromium/src/+/a9a3cc01ede1daea073f9a307e689893329bf315

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
Finnur
https://codereview.chromium.org/2889563002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java File chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java (right): https://codereview.chromium.org/2889563002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java#newcode154 chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java:154: } This is a piece of code we discussed ...
3 years, 7 months ago (2017-05-16 13:38:15 UTC) #4
Theresa
lgtm
3 years, 7 months ago (2017-05-16 15:02:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889563002/1
3 years, 7 months ago (2017-05-16 15:53:36 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 16:04:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9a3cc01ede1daea073f9a307e68...

Powered by Google App Engine
This is Rietveld 408576698