Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4756)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java

Issue 2889563002: Photo Picker dialog: Fix single-selection bug. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
index 556087fc9bc10e07160b97caf124d56e4789f3f0..aa1a1db2e1d1609e02fd6e829e756b2553d68e38 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
@@ -146,6 +146,13 @@ public class PickerBitmapView extends SelectableItemView<PickerBitmap> {
boolean selected = selectedItems.contains(mBitmapDetails);
boolean checked = super.isChecked();
+
+ // In single-selection mode, the list needs to be updated to account for items that were
+ // checked before but no longer are (because something else was selected).
+ if (!mCategoryView.isMultiSelectAllowed() && !selected && checked) {
+ super.toggle();
+ }
Finnur 2017/05/16 13:38:15 This is a piece of code we discussed earlier and I
+
boolean needsResize = selected != checked;
int size = selected && !checked ? mCategoryView.getImageSize() - 2 * mBorder
: mCategoryView.getImageSize();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698