Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(299)

Issue 2889153007: Update run_gtest_perf_test.py to streaming command output to stdout & log file at the same time (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by nednguyen
Modified:
4 months ago
Reviewers:
dnj, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update run_gtest_perf_test.py to streaming command output to stdout & log file at the same time BUG=723821 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2889153007 Cr-Commit-Position: refs/heads/master@{#473376} Committed: https://chromium.googlesource.com/chromium/src/+/c3648c4f352731076b62b779597e40fed8db78e6

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address Daniel's comments #

Total comments: 8

Patch Set 3 : Address Daniel's comments #

Messages

Total messages: 21 (12 generated)
nednguyen
4 months ago (2017-05-19 19:48:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889153007/20001
4 months ago (2017-05-19 19:51:41 UTC) #6
Dirk Pranke
I defer to dnj@ here. lgtm if/when he approves.
4 months ago (2017-05-19 20:09:29 UTC) #9
dnj
https://codereview.chromium.org/2889153007/diff/20001/testing/scripts/common.py File testing/scripts/common.py (right): https://codereview.chromium.org/2889153007/diff/20001/testing/scripts/common.py#newcode78 testing/scripts/common.py:78: rc = 1 No point setting this here. https://codereview.chromium.org/2889153007/diff/20001/testing/scripts/common.py#newcode81 ...
4 months ago (2017-05-19 20:56:19 UTC) #10
nednguyen
https://codereview.chromium.org/2889153007/diff/20001/testing/scripts/common.py File testing/scripts/common.py (right): https://codereview.chromium.org/2889153007/diff/20001/testing/scripts/common.py#newcode78 testing/scripts/common.py:78: rc = 1 On 2017/05/19 20:56:18, dnj wrote: > ...
4 months ago (2017-05-19 21:21:23 UTC) #11
dnj
lgtm w/ comments/nits https://codereview.chromium.org/2889153007/diff/40001/testing/scripts/common.py File testing/scripts/common.py (right): https://codereview.chromium.org/2889153007/diff/40001/testing/scripts/common.py#newcode76 testing/scripts/common.py:76: def run_command_with_output(argv, stdoutfile, env=None, cwd=None, ): ...
4 months ago (2017-05-19 21:27:16 UTC) #14
nednguyen
https://codereview.chromium.org/2889153007/diff/40001/testing/scripts/common.py File testing/scripts/common.py (right): https://codereview.chromium.org/2889153007/diff/40001/testing/scripts/common.py#newcode76 testing/scripts/common.py:76: def run_command_with_output(argv, stdoutfile, env=None, cwd=None, ): On 2017/05/19 21:27:16, ...
4 months ago (2017-05-19 21:31:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889153007/60001
4 months ago (2017-05-19 21:33:58 UTC) #18
commit-bot: I haz the power
4 months ago (2017-05-19 22:55:11 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c3648c4f352731076b62b779597e...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b