Update run_gtest_perf_test.py to streaming command output to stdout & log file at the same time

testing/scripts/common.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import contextlib
+import io
 import json
 import os
+import logging
 import subprocess
 import sys
 import tempfile
+import time
 
 
 SCRIPT_DIR = os.path.abspath(os.path.dirname(__file__))
 SRC_DIR = os.path.abspath(
     os.path.join(SCRIPT_DIR, os.path.pardir, os.path.pardir))
 
 
 # run-webkit-tests returns the number of failures as the return
 # code, but caps the return code at 101 to avoid overflow or colliding
 # with reserved values from the shell.
@@ skipping 41 matching lines @@
   return args.func(args)
 
 
 def run_command(argv, env=None, cwd=None):
   print 'Running %r in %r (env: %r)' % (argv, cwd, env)
   rc = subprocess.call(argv, env=env, cwd=cwd)
   print 'Command %r returned exit code %d' % (argv, rc)
   return rc
 
 
-def run_command_with_output(argv, env=None, cwd=None, stdoutfile=None):
+def run_command_with_output(argv, stdoutfile, env=None, cwd=None, ):

[dnj, 2017/05/19 21:27:16]

Nit, trailing comma.

[nednguyen, 2017/05/19 21:31:15]

Done.

+  """ Run command and stream its stdout/stderr to the console & |stdoutfile|.
+  """
   print 'Running %r in %r (env: %r)' % (argv, cwd, env)
-  rc = 1
-  try:
-    output = subprocess.check_output(argv, env=env, cwd=cwd,
-        stderr=subprocess.STDOUT)
-    if stdoutfile:
-      with open(stdoutfile, 'w') as fp:
-        fp.write(output)
-    rc = 0
-  except Exception:
-    # Exit code remains 1 and we don't write output
-    pass
-  print 'Command %r returned exit code %d' % (argv, rc)
-  return rc
+  assert stdoutfile
+  with io.open(stdoutfile, 'wb') as writer:

[dnj, 2017/05/19 21:27:16]

Nit, you can combine this into a single block:

with io.open(...) as writer, io.open(...) as reader:

[nednguyen, 2017/05/19 21:31:14]

Done.

+    with io.open(stdoutfile, 'rb', 1) as reader:

[dnj, 2017/05/19 21:27:16]

Note: the original used "w" (text-mode); "wb" and "rb" are *probably* fine, but
double-check that nothing relied on Python's text conversion.

[nednguyen, 2017/05/19 21:31:15]

Oh, I just use "w" & "r" here to be sure.

+      process = subprocess.Popen(argv, env=env, cwd=cwd, stdout=writer,
+          stderr=subprocess.STDOUT)
+      while process.poll() is None:
+        sys.stdout.write(reader.read())
+        time.sleep(1)

[dnj, 2017/05/19 21:27:16]

Note: if the subprocess is fast and repeated (e.g., 100x 10ms surprocesses),
this will add real delay. Consider something more aggressive, like sleep(0.1).

[nednguyen, 2017/05/19 21:31:15]

Done.

+      # Read the remaining
+      sys.stdout.write(reader.read())
+      print 'Command %r returned exit code %d' % (argv, process.returncode)
+      return process.returncode
 
 
 def run_runtest(cmd_args, runtest_args):
   if cmd_args.use_src_side_runtest_py:
     cmd = [
       sys.executable,
       os.path.join(
           cmd_args.paths['checkout'], 'infra', 'scripts', 'runtest_wrapper.py'),
       '--',
     ]
@@ skipping 82 matching lines @@
       [sys.executable, script_to_run] + extra_args)
 
   with open(log_file) as f:
     failures = json.load(f)
   json.dump({
       'valid': integration_test_res == 0,
       'failures': failures,
   }, output)
 
   return integration_test_res