Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2889143003: [NTP] Show category id in snippets internals. (Closed)

Created:
3 years, 7 months ago by vitaliii
Modified:
3 years, 7 months ago
Reviewers:
jkrcal
CC:
chromium-reviews, noyau+watch_chromium.org, arv+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Show category id in snippets internals. This is useful for debugging remote categories. Please see the bug for a screenshot. BUG=723993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2889143003 Cr-Commit-Position: refs/heads/master@{#472862} Committed: https://chromium.googlesource.com/chromium/src/+/fcb1d8f15cc7b201adde93d7756ad629e83e80b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/snippets_internals.html View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
vitaliii
[1 line CL] Hi jkrcal@, Could you have a look please?
3 years, 7 months ago (2017-05-18 13:37:14 UTC) #5
jkrcal
lgtm
3 years, 7 months ago (2017-05-18 13:42:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889143003/1
3 years, 7 months ago (2017-05-18 13:45:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889143003/1
3 years, 7 months ago (2017-05-18 14:59:40 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:45:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fcb1d8f15cc7b201adde93d7756a...

Powered by Google App Engine
This is Rietveld 408576698