Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2893933002:
[NTP] Mobile friendly buttons on snippets internals. (Closed)
|
Created:
3 years, 7 months ago by vitaliii Modified:
3 years, 7 months ago Reviewers:
markusheintz_ CC:
chromium-reviews, noyau+watch_chromium.org, arv+watch_chromium.org, ntp-dev+reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[NTP] Mobile friendly buttons on snippets internals.
Previously the buttons were very wide, but not high enough. Moreover, some were too close to each other.
Please see screenshots in the bug.
BUG=724080
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2893933002
Cr-Commit-Position: refs/heads/master@{#473857}
Committed: https://chromium.googlesource.com/chromium/src/+/1783a047f99d3222d452296f59174087d4366d0a
Patch Set 1 #Patch Set 2 : clean rebase. #Patch Set 3 : clean rebase. #
Messages
Total messages: 27 (21 generated)
Description was changed from ========== [NTP] Mobile friendly buttons on snippets internals. Previously there way wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=723993 ========== to ========== [NTP] Mobile friendly buttons on snippets internals. Previously there way wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=723993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [NTP] Mobile friendly buttons on snippets internals. Previously there way wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=723993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [NTP] Mobile friendly buttons on snippets internals. Previously there way wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=724080 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vitaliii@chromium.org changed reviewers: + markusheintz@chromium.org
Hi markusheintz@, Could you have a look please?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping.
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/22 09:52:59, vitaliii wrote: > ping. LGTM after fixing the CL description
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [NTP] Mobile friendly buttons on snippets internals. Previously there way wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=724080 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [NTP] Mobile friendly buttons on snippets internals. Previously the buttons were very wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=724080 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
I've fixed description, no need to look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was unchecked by vitaliii@chromium.org
The CQ bit was checked by vitaliii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from markusheintz@chromium.org Link to the patchset: https://codereview.chromium.org/2893933002/#ps40001 (title: "clean rebase.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495532861559910,
"parent_rev": "b464b3efcea3392d5254e4bb55053916801fcef7", "commit_rev":
"1783a047f99d3222d452296f59174087d4366d0a"}
Message was sent while issue was closed.
Description was changed from ========== [NTP] Mobile friendly buttons on snippets internals. Previously the buttons were very wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=724080 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [NTP] Mobile friendly buttons on snippets internals. Previously the buttons were very wide, but not high enough. Moreover, some were too close to each other. Please see screenshots in the bug. BUG=724080 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2893933002 Cr-Commit-Position: refs/heads/master@{#473857} Committed: https://chromium.googlesource.com/chromium/src/+/1783a047f99d3222d452296f5917... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1783a047f99d3222d452296f5917... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
