Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2889093002:
[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation_internal to ARC. (Closed)
|
Created:
3 years, 7 months ago by liaoyuke Modified:
3 years, 6 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mlamouri+watch-geolocation_chromium.org, pkl (ping after 24h if needed), mcasas+geolocation_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation_internal to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Review-Url: https://codereview.chromium.org/2889093002
Cr-Commit-Position: refs/heads/master@{#479687}
Committed: https://chromium.googlesource.com/chromium/src/+/8617ad05b5fa2d087657008cb74b73b9cb3a1050
Patch Set 1 #
Total comments: 8
Patch Set 2 : Addressed comments #
Total comments: 4
Patch Set 3 : Remove the weak annotations. #
Messages
Total messages: 20 (9 generated)
The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
liaoyuke@chromium.org changed reviewers: + sdefresne@chromium.org
Hi Sylvain, PTAL. Thank you very much!
https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... File ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm (right): https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:123: @property(weak, nonatomic, readonly) OmniboxGeolocationLocalState* localState; nit: This should be @property(nonatomic, weak, readonly). https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:126: @property(weak, nonatomic, readonly) LocationManager* locationManager; ditto https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:555: // Just resetting |authorizationAlert_| leads to a user-after-free crash Remove this comment. https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:570: // Just resetting |authorizationAlert_| leads to a user-after-free crash Remove this comment.
Sorry for the delay, got stuck on the tests timeout issue. PTAL. Thank you very much! https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... File ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm (right): https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:123: @property(weak, nonatomic, readonly) OmniboxGeolocationLocalState* localState; On 2017/05/31 07:53:28, sdefresne wrote: > nit: This should be @property(nonatomic, weak, readonly). Done. https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:126: @property(weak, nonatomic, readonly) LocationManager* locationManager; On 2017/05/31 07:53:28, sdefresne wrote: > ditto Done. https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:555: // Just resetting |authorizationAlert_| leads to a user-after-free crash On 2017/05/31 07:53:28, sdefresne wrote: > Remove this comment. Done. https://codereview.chromium.org/2889093002/diff/1/ios/chrome/browser/geolocat... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:570: // Just resetting |authorizationAlert_| leads to a user-after-free crash On 2017/05/31 07:53:28, sdefresne wrote: > Remove this comment. Done.
https://codereview.chromium.org/2889093002/diff/20001/ios/chrome/browser/geol... File ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm (right): https://codereview.chromium.org/2889093002/diff/20001/ios/chrome/browser/geol... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:123: @property(nonatomic, weak, readonly) OmniboxGeolocationLocalState* localState; The "weak" annotation is incorrect as the ivar is "strong". Since original code used scoped_nsobject<> the intention is to have a strong property, thus this should be changed to "strong" in the @property. https://codereview.chromium.org/2889093002/diff/20001/ios/chrome/browser/geol... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:126: @property(nonatomic, weak, readonly) LocationManager* locationManager; ditto
stkhapugin@chromium.org changed reviewers: + stkhapugin@chromium.org
kindly ping
PTAL sdefresne@, Thank you very much! https://codereview.chromium.org/2889093002/diff/20001/ios/chrome/browser/geol... File ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm (right): https://codereview.chromium.org/2889093002/diff/20001/ios/chrome/browser/geol... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:123: @property(nonatomic, weak, readonly) OmniboxGeolocationLocalState* localState; On 2017/06/07 09:22:23, sdefresne wrote: > The "weak" annotation is incorrect as the ivar is "strong". Since original code > used scoped_nsobject<> the intention is to have a strong property, thus this > should be changed to "strong" in the @property. Correct, thank you for the detailed review. The script added the "weak" automatically, seems that there is a bug with the script, I'll let Stepan know and fix it. https://codereview.chromium.org/2889093002/diff/20001/ios/chrome/browser/geol... ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm:126: @property(nonatomic, weak, readonly) LocationManager* locationManager; On 2017/06/07 09:22:24, sdefresne wrote: > ditto Done.
lgtm
On 2017/06/14 16:09:00, stkhapugin wrote: > lgtm Thanks! sdefresne@ please do an owner's approval.
lgtm
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497530056577060,
"parent_rev": "f1cb1a54fb8f1f89f572090bd68be376e2bc21f4", "commit_rev":
"8617ad05b5fa2d087657008cb74b73b9cb3a1050"}
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2889093002 Cr-Commit-Position: refs/heads/master@{#479687} Committed: https://chromium.googlesource.com/chromium/src/+/8617ad05b5fa2d087657008cb74b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8617ad05b5fa2d087657008cb74b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
