[ObjC ARC] Converts ios/chrome/browser/geolocation:geolocation_internal to ARC.

ios/chrome/browser/geolocation/omnibox_geolocation_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/geolocation/omnibox_geolocation_controller.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <string>
 
-#import "base/ios/weak_nsobject.h"
 #include "base/logging.h"
-#include "base/mac/scoped_nsobject.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/version.h"
 #include "components/google/core/browser/google_util.h"
 #include "components/version_info/version_info.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #import "ios/chrome/browser/geolocation/CLLocation+OmniboxGeolocation.h"
 #import "ios/chrome/browser/geolocation/CLLocation+XGeoHeader.h"
 #import "ios/chrome/browser/geolocation/location_manager.h"
 #import "ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.h"
 #import "ios/chrome/browser/geolocation/omnibox_geolocation_config.h"
 #import "ios/chrome/browser/geolocation/omnibox_geolocation_controller+Testing.h"
 #import "ios/chrome/browser/geolocation/omnibox_geolocation_local_state.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #include "ios/web/public/navigation_item.h"
 #import "ios/web/public/navigation_manager.h"
 #include "url/gurl.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 
 // Values for the histogram that records whether we sent the X-Geo header for
 // an Omnibox query or why we did not do so. These match the definition of
 // GeolocationHeaderSentOrNot in Chromium
 // src-internal/tools/histograms/histograms.xml.
 typedef enum {
   // The user disabled location for Google.com (not used by Chrome iOS).
   kHeaderStateNotSentAuthorizationGoogleDenied = 0,
   // The user has not yet determined Chrome's access to the current device
@@ skipping 48 matching lines @@
 
 // Name of the histogram recording AuthorizationAction for a new user.
 const char* const kGeolocationAuthorizationActionNewUser =
     "Geolocation.AuthorizationActionNewUser";
 
 }  // anonymous namespace
 
 @interface OmniboxGeolocationController ()<
     LocationManagerDelegate,
     OmniboxGeolocationAuthorizationAlertDelegate> {
-  base::scoped_nsobject<OmniboxGeolocationLocalState> localState_;
-  base::scoped_nsobject<LocationManager> locationManager_;
-  base::scoped_nsobject<OmniboxGeolocationAuthorizationAlert>
-      authorizationAlert_;
-  base::WeakNSObject<Tab> weakTabToReload_;
+  OmniboxGeolocationLocalState* localState_;
+  LocationManager* locationManager_;
+  OmniboxGeolocationAuthorizationAlert* authorizationAlert_;
+  __weak Tab* weakTabToReload_;
 
   // Records whether we have deliberately presented the system prompt, so that
   // we can record the user's action in
   // locationManagerDidChangeAuthorizationStatus:.
   BOOL systemPrompt_;
 
   // Records whether we are prompting for a new user, so that we can record the
   // user's action to the right histogram (either
   // kGeolocationAuthorizationActionExistingUser or
   // kGeolocationAuthorizationActionNewUser).
@@ skipping 69 matching lines @@
     // TODO(crbug.com/661996): Remove the now useless
     // kAuthorizationStateNotDeterminedSystemPrompt from
     // omnibox_geolocation_local_state.h.
     systemPrompt_ = YES;
     self.localState.authorizationState =
         geolocation::kAuthorizationStateNotDeterminedSystemPrompt;
 
     // Turn on location updates, so that iOS will prompt the user.
     [self startUpdatingLocation];
 
-    weakTabToReload_.reset();
+    weakTabToReload_ = nil;
     newUser_ = newUser;
   }
 }
 
 - (void)locationBarDidBecomeFirstResponder:
     (ios::ChromeBrowserState*)browserState {
   if (self.enabled && browserState && !browserState->IsOffTheRecord()) {
     [self startUpdatingLocation];
   }
 }
@@ skipping 131 matching lines @@
       // Set |systemPrompt_|, so that
       // locationManagerDidChangeAuthorizationStatus: will know that any
       // CLAuthorizationStatus changes are coming from this specific prompt.
       systemPrompt_ = YES;
       self.localState.authorizationState =
           geolocation::kAuthorizationStateNotDeterminedSystemPrompt;
       [self startUpdatingLocation];
 
       // Save this tab in case we're able to transition to
       // kAuthorizationStateAuthorized.
-      weakTabToReload_.reset(tab);
+      weakTabToReload_ = tab;
       break;
 
     case kCLAuthorizationStatusRestricted:
     case kCLAuthorizationStatusDenied:
       break;
 
     case kCLAuthorizationStatusAuthorizedAlways:
     case kCLAuthorizationStatusAuthorizedWhenInUse:
       // We might be in state kAuthorizationStateNotDeterminedSystemPrompt here
       // if we presented the iOS system location alert when
@@ skipping 21 matching lines @@
 #pragma mark - Private
 
 - (BOOL)enabled {
   return self.locationManager.locationServicesEnabled &&
          self.localState.authorizationState ==
              geolocation::kAuthorizationStateAuthorized;
 }
 
 - (OmniboxGeolocationLocalState*)localState {
   if (!localState_) {
-    localState_.reset([[OmniboxGeolocationLocalState alloc]
-        initWithLocationManager:self.locationManager]);
+    localState_ = [[OmniboxGeolocationLocalState alloc]
+        initWithLocationManager:self.locationManager];
   }
   return localState_;
 }
 
 - (LocationManager*)locationManager {
   if (!locationManager_) {
-    locationManager_.reset([[LocationManager alloc] init]);
+    locationManager_ = [[LocationManager alloc] init];
     [locationManager_ setDelegate:self];
   }
   return locationManager_;
 }
 
 - (BOOL)URLIsEligibleQueryURL:(const GURL&)url
                    transition:(ui::PageTransition)transition {
   return [self URLIsQueryURL:url transition:transition] &&
          [[OmniboxGeolocationConfig sharedInstance] URLHasEligibleDomain:url];
 }
@@ skipping 62 matching lines @@
     return YES;
 
   base::Version currentVersion(version_info::GetVersionNumber());
   DCHECK(currentVersion.IsValid());
   return currentVersion.components()[0] != previousVersion.components()[0];
 }
 
 - (void)showAuthorizationAlertForTab:(Tab*)tab {
   // Save this tab in case we're able to transition to
   // kAuthorizationStateAuthorized.
-  weakTabToReload_.reset(tab);
+  weakTabToReload_ = tab;
 
-  authorizationAlert_.reset(
-      [[OmniboxGeolocationAuthorizationAlert alloc] initWithDelegate:self]);
+  authorizationAlert_ =
+      [[OmniboxGeolocationAuthorizationAlert alloc] initWithDelegate:self];
   [authorizationAlert_ showAuthorizationAlert];
 
   self.localState.lastAuthorizationAlertVersion =
       version_info::GetVersionNumber();
 }
 
 - (void)recordHeaderState:(HeaderState)headerState {
   UMA_HISTOGRAM_ENUMERATION(kGeolocationHeaderSentOrNotHistogram, headerState,
                             kHeaderStateCount);
 }
@@ skipping 31 matching lines @@
 
         [self recordAuthorizationAction:kAuthorizationActionPermanentlyDenied];
         break;
 
       case kCLAuthorizationStatusAuthorizedAlways:
       case kCLAuthorizationStatusAuthorizedWhenInUse:
         self.localState.authorizationState =
             geolocation::kAuthorizationStateAuthorized;
         systemPrompt_ = NO;
 
-        base::scoped_nsobject<Tab> tab([weakTabToReload_ retain]);
+        Tab* tab = weakTabToReload_;
         [self addLocationAndReloadTab:tab];
-        weakTabToReload_.reset();
+        weakTabToReload_ = nil;
 
         [self recordAuthorizationAction:kAuthorizationActionAuthorized];
         break;
     }
   }
 }
 
 #pragma mark - OmniboxGeolocationAuthorizationAlertDelegate
 
 - (void)authorizationAlertDidAuthorize:
     (OmniboxGeolocationAuthorizationAlert*)authorizationAlert {
   self.localState.authorizationState =
       geolocation::kAuthorizationStateAuthorized;
 
-  base::scoped_nsobject<Tab> tab([weakTabToReload_ retain]);
+  Tab* tab = weakTabToReload_;
   [self addLocationAndReloadTab:tab];
 
-  // Just resetting |authorizationAlert_| leads to a user-after-free crash
-  // presumably due to a UIKit bug. Making authorizationAlert_ autorelease
-  // will keep it alive long enough to avoid the crash. See crbug.com/381235
-  authorizationAlert_.autorelease();
-  weakTabToReload_.reset();
+  authorizationAlert_ = nil;
+  weakTabToReload_ = nil;
 
   [self recordAuthorizationAction:kAuthorizationActionAuthorized];
 }
 
 - (void)authorizationAlertDidCancel:
     (OmniboxGeolocationAuthorizationAlert*)authorizationAlert {
   // Leave authorization state as undetermined (not kAuthorizationStateDenied).
   // We won't use location, but we'll still be able to prompt at the next
   // application update.
 
-  // Just resetting |authorizationAlert_| leads to a user-after-free crash
-  // presumably due to a UIKit bug. Making authorizationAlert_ autorelease
-  // will keep it alive long enough to avoid the crash. See crbug.com/381235
-  authorizationAlert_.autorelease();
-  weakTabToReload_.reset();
+  authorizationAlert_ = nil;
+  weakTabToReload_ = nil;
 
   [self recordAuthorizationAction:kAuthorizationActionDenied];
 }
 
 #pragma mark - OmniboxGeolocationController+Testing
 
 - (void)setLocalState:(OmniboxGeolocationLocalState*)localState {
-  localState_.reset([localState retain]);
+  localState_ = localState;
 }
 
 - (void)setLocationManager:(LocationManager*)locationManager {
-  locationManager_.reset([locationManager retain]);
+  locationManager_ = locationManager;
 }
 
 @end