Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h

Issue 2888803002: Handle WebContentsViewMac being destroyed while a <select> menu is showing. (Closed)
Patch Set: respond to comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h
diff --git a/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h b/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h
index 7dc9b6582a2c7bb52067e34a76a4edf97022764e..ebb46abce681444f7328a41a5a0c480eff8d4688 100644
--- a/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h
+++ b/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h
@@ -15,7 +15,8 @@ class RenderFrameHostImpl;
// This class is similiar to PopupMenuHelperMac but positions the popup relative
// to the embedder, and issues a reply to the guest.
-class BrowserPluginPopupMenuHelper : public PopupMenuHelper {
+class BrowserPluginPopupMenuHelper : public PopupMenuHelper,
+ public PopupMenuHelper::Delegate {
public:
// Creates a BrowserPluginPopupMenuHelper that positions popups relative to
// |embedder_rfh| and will notify |guest_rfh| when a user selects or cancels
@@ -24,8 +25,12 @@ class BrowserPluginPopupMenuHelper : public PopupMenuHelper {
RenderFrameHost* guest_rfh);
private:
+ // PopupMenuHelper:
RenderWidgetHostViewMac* GetRenderWidgetHostView() const override;
+ // PopupMenuHelper:Delegate:
+ void OnMenuClosed() override;
+
RenderFrameHostImpl* embedder_rfh_;
DISALLOW_COPY_AND_ASSIGN(BrowserPluginPopupMenuHelper);
« no previous file with comments | « chrome/test/data/select.html ('k') | content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698