Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm

Issue 2888803002: Handle WebContentsViewMac being destroyed while a <select> menu is showing. (Closed)
Patch Set: respond to comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm
diff --git a/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm b/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm
index 1874747f97f3033c8fa730195eaaa78672287604..1784e0e900f3771c5559bd18f62c1d6a79a2e8f7 100644
--- a/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm
+++ b/content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm
@@ -13,11 +13,16 @@ namespace content {
BrowserPluginPopupMenuHelper::BrowserPluginPopupMenuHelper(
RenderFrameHostImpl* embedder_rfh,
RenderFrameHost* guest_rfh)
- : PopupMenuHelper(guest_rfh), embedder_rfh_(embedder_rfh) {}
+ : PopupMenuHelper(this, guest_rfh), embedder_rfh_(embedder_rfh) {}
RenderWidgetHostViewMac*
BrowserPluginPopupMenuHelper::GetRenderWidgetHostView() const {
return static_cast<RenderWidgetHostViewMac*>(embedder_rfh_->GetView());
}
+void BrowserPluginPopupMenuHelper::OnMenuClosed() {
+ // BrowserPluginGuest doesn't support cancellation of popup menus, so the
+ // MenuHelper is its own delegate and OnMenuClosed() is ignored.
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698