Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h

Issue 2888803002: Handle WebContentsViewMac being destroyed while a <select> menu is showing. (Closed)
Patch Set: respond to comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_POPUP_MENU_HELPER_MAC_H_ 5 #ifndef CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_POPUP_MENU_HELPER_MAC_H_
6 #define CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_POPUP_MENU_HELPER_MAC_H_ 6 #define CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_POPUP_MENU_HELPER_MAC_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "content/browser/frame_host/popup_menu_helper_mac.h" 9 #include "content/browser/frame_host/popup_menu_helper_mac.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 class RenderFrameHost; 13 class RenderFrameHost;
14 class RenderFrameHostImpl; 14 class RenderFrameHostImpl;
15 15
16 // This class is similiar to PopupMenuHelperMac but positions the popup relative 16 // This class is similiar to PopupMenuHelperMac but positions the popup relative
17 // to the embedder, and issues a reply to the guest. 17 // to the embedder, and issues a reply to the guest.
18 class BrowserPluginPopupMenuHelper : public PopupMenuHelper { 18 class BrowserPluginPopupMenuHelper : public PopupMenuHelper,
19 public PopupMenuHelper::Delegate {
19 public: 20 public:
20 // Creates a BrowserPluginPopupMenuHelper that positions popups relative to 21 // Creates a BrowserPluginPopupMenuHelper that positions popups relative to
21 // |embedder_rfh| and will notify |guest_rfh| when a user selects or cancels 22 // |embedder_rfh| and will notify |guest_rfh| when a user selects or cancels
22 // the popup. 23 // the popup.
23 BrowserPluginPopupMenuHelper(RenderFrameHostImpl* embedder_rfh, 24 BrowserPluginPopupMenuHelper(RenderFrameHostImpl* embedder_rfh,
24 RenderFrameHost* guest_rfh); 25 RenderFrameHost* guest_rfh);
25 26
26 private: 27 private:
28 // PopupMenuHelper:
27 RenderWidgetHostViewMac* GetRenderWidgetHostView() const override; 29 RenderWidgetHostViewMac* GetRenderWidgetHostView() const override;
28 30
31 // PopupMenuHelper:Delegate:
32 void OnMenuClosed() override;
33
29 RenderFrameHostImpl* embedder_rfh_; 34 RenderFrameHostImpl* embedder_rfh_;
30 35
31 DISALLOW_COPY_AND_ASSIGN(BrowserPluginPopupMenuHelper); 36 DISALLOW_COPY_AND_ASSIGN(BrowserPluginPopupMenuHelper);
32 }; 37 };
33 38
34 } // namespace content 39 } // namespace content
35 40
36 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_POPUP_MENU_HELPER_MAC_H _ 41 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_POPUP_MENU_HELPER_MAC_H _
OLDNEW
« no previous file with comments | « chrome/test/data/select.html ('k') | content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698