Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2888713004: Clean up logging around browser relaunch in gpu_integration_test.py. (Closed)

Created:
3 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Zhenyao Mo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up logging around browser relaunch in gpu_integration_test.py. Though this was mostly subsumed into Telemetry's desktop_browser_finder, the gpu_integration_test_unittests in particular demonstrate that a retry loop is still needed here in some situations. BUG=718300 TBR=nednguyen@google.com CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2888713004 Cr-Commit-Position: refs/heads/master@{#472334} Committed: https://chromium.googlesource.com/chromium/src/+/b1226755d23b14fe273acd625806455a0a00e199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Ken Russell (switch to Gerrit)
Ned: I wasn't able to get rid of the retry loop for launching the browser ...
3 years, 7 months ago (2017-05-16 22:38:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888713004/1
3 years, 7 months ago (2017-05-16 22:39:39 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 05:05:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1226755d23b14fe273acd625806...

Powered by Google App Engine
This is Rietveld 408576698