Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: content/test/gpu/gpu_tests/gpu_integration_test.py

Issue 2888713004: Clean up logging around browser relaunch in gpu_integration_test.py. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/gpu_integration_test.py
diff --git a/content/test/gpu/gpu_tests/gpu_integration_test.py b/content/test/gpu/gpu_tests/gpu_integration_test.py
index 9bdc7afcb3c3f585b1fc35fa4d78c83b5456718a..908c8164f28729e9d282c1431211fcfb9b166d77 100644
--- a/content/test/gpu/gpu_tests/gpu_integration_test.py
+++ b/content/test/gpu/gpu_tests/gpu_integration_test.py
@@ -23,15 +23,18 @@ class GpuIntegrationTest(
@classmethod
def StartBrowser(cls):
+ # We still need to retry the browser's launch even though
+ # desktop_browser_finder does so too, because it wasn't possible
+ # to push the fetch of the first tab into the lower retry loop
+ # without breaking Telemetry's unit tests, and that hook is used
+ # to implement the gpu_integration_test_unittests.
for x in range(0, 3):
try:
- restart = 'Starting browser, attempt %d of 3' % (x + 1)
- logging.warning(restart)
super(GpuIntegrationTest, cls).StartBrowser()
cls.tab = cls.browser.tabs[0]
- logging.warning('Started browser successfully.')
return
except Exception:
+ logging.warning('Browser start failed (attempt %d of 3)', (x + 1))
# If we are on the last try and there is an exception take a screenshot
# to try and capture more about the browser failure and raise
if x == 2:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698