Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2888683002: DevTools: Fix timeline overview popover sticking at last (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix timeline overview popover sticking at last Review-Url: https://codereview.chromium.org/2888683002 Cr-Commit-Position: refs/heads/master@{#472231} Committed: https://chromium.googlesource.com/chromium/src/+/5b36d3236be6e4431ef8307bfbb0aed6187fe24b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js View 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/timelineOverviewInfo.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
alph
3 years, 7 months ago (2017-05-16 19:29:34 UTC) #2
caseq
lgtm
3 years, 7 months ago (2017-05-16 19:36:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888683002/1
3 years, 7 months ago (2017-05-16 19:37:27 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 22:30:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b36d3236be6e4431ef8307bfbb0...

Powered by Google App Engine
This is Rietveld 408576698