third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js - Issue 2888683002: DevTools: Fix timeline overview popover sticking at last

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js

Issue 2888683002: DevTools: Fix timeline overview popover sticking at last (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js

index deb9fba02c5bc082357e025767a9bd0c95aca8a8..9edd0b7d59ba84385136cc14d6ef38d1dfe04565 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js

@@ -990,7 +990,7 @@ Timeline.TimelineFlameChartDataProvider = class extends Common.Object {

* @return {?SDK.TracingModel.Event}

eventByIndex(entryIndex) {

- return this._entryType(entryIndex) === Timeline.TimelineFlameChartDataProvider.EntryType.Event ?

+ return entryIndex >= 0 && this._entryType(entryIndex) === Timeline.TimelineFlameChartDataProvider.EntryType.Event ?

/** @type {!SDK.TracingModel.Event} */ (this._entryData[entryIndex]) :

null;

}

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/perf_ui/timelineOverviewInfo.css ('k') | no next file » | no next file with comments »