chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h - Issue 2888673002: Add support for counting same-document AMP loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

Issue 2888673002: Add support for counting same-document AMP loads. (Closed)

Patch Set: comment cleanup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

index af156579b7750d92db0c107e8b73b3b604dd551b..7826ec873b8a6348136d74ff75f2129d29725ff3 100644

--- a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

@@ -27,7 +27,7 @@ class AdsPageLoadMetricsObserver

// page_load_metrics::PageLoadMetricsObserver

ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;

- ObservePolicy OnDidFinishSubFrameNavigation(

+ void OnDidFinishSubFrameNavigation(

RyanSturm 2017/05/16 22:32:10 Is the OnDidFinishSubFrameNavigation change unrela

Bryan McQuade 2017/05/17 12:38:34 Yeah - unrelated - I didn't want to make the new m

content::NavigationHandle* navigation_handle) override;

ObservePolicy FlushMetricsOnAppEnterBackground(

const page_load_metrics::PageLoadTiming& timing,