chrome/browser/page_load_metrics/metrics_web_contents_observer.cc - Issue 2888673002: Add support for counting same-document AMP loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2888673002: Add support for counting same-document AMP loads. (Closed)

Patch Set: comment cleanup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

index 711eed8760f7c30adc9699d412f778bc571a9d3c..51b94a467e9147c34d0144d92f425b60cfd7b85e 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

@@ -331,6 +331,8 @@ void MetricsWebContentsObserver::DidFinishNavigation(

navigation_handle->IsSameDocument()) {

if (finished_nav)

finished_nav->StopTracking();

+ if (committed_load_)

+ committed_load_->DidCommitSameDocumentNavigation(navigation_handle);

return;

}