Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2888633002: Revert of [Autofill] Enable Autofill UKM by default. (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
csashi, Mathieu, sebsg
CC:
chromium-reviews, rouslan+payments_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sebsg+paymentswatch_chromium.org, csashi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Autofill] Enable Autofill UKM by default. (patchset #4 id:60001 of https://codereview.chromium.org/2874413004/ ) Reason for revert: Failing consistently on chromium.memory/Linux ASan LSan Tests (1) See crbug.com/722947 Original issue's description: > [Autofill] Enable Autofill UKM by default. > > BUG=718014 > > Review-Url: https://codereview.chromium.org/2874413004 > Cr-Commit-Position: refs/heads/master@{#472094} > Committed: https://chromium.googlesource.com/chromium/src/+/06fc093968064421daf828caf503ef5fafb07cba TBR=csashi@google.com,mathp@chromium.org,sebsg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=718014 Review-Url: https://codereview.chromium.org/2888633002 Cr-Commit-Position: refs/heads/master@{#472178} Committed: https://chromium.googlesource.com/chromium/src/+/3573e1fcb10702a8d842cef0ca9ff2825a4c85db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -10 lines) Patch
M components/autofill/core/browser/autofill_experiments.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 28 chunks +30 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 23 chunks +54 lines, -0 lines 0 comments Download
M components/payments/core/journey_logger.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/payments/core/journey_logger_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dmazzoni
Created Revert of [Autofill] Enable Autofill UKM by default.
3 years, 7 months ago (2017-05-16 18:46:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888633002/1
3 years, 7 months ago (2017-05-16 18:48:24 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 18:50:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3573e1fcb10702a8d842cef0ca9f...

Powered by Google App Engine
This is Rietveld 408576698